Remove Checkstyle redundant implementation.#3465
Merged
DarshitChanpura merged 1 commit intoopensearch-project:mainfrom Oct 6, 2023
Merged
Remove Checkstyle redundant implementation.#3465DarshitChanpura merged 1 commit intoopensearch-project:mainfrom
DarshitChanpura merged 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
Author
|
@peternied @cwperks Sorry, I broke the other branch, but I took your considerations. |
Member
|
@davidosorno Can you re-base this from main. There was a build fixing change merged 1 hr ago: #3463 As a plugin, this repo is at the whims of breaking changes being merged into the upstream core repo. If an API changes in that repo that is used in this repo it fails the build because it can't compile. Thank you for being on top of the re-bases! |
Signed-off-by: David Osorno <daosgu27@gmail.com>
c1abd06 to
3503001
Compare
Codecov Report
@@ Coverage Diff @@
## main #3465 +/- ##
============================================
+ Coverage 64.58% 64.60% +0.01%
Complexity 3575 3575
============================================
Files 275 275
Lines 20451 20451
Branches 3382 3382
============================================
+ Hits 13208 13212 +4
+ Misses 5546 5544 -2
+ Partials 1697 1695 -2 |
willyborankin
approved these changes
Oct 6, 2023
DarshitChanpura
approved these changes
Oct 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
Signed-off-by: David Osorno <daosgu27@gmail.com> (cherry picked from commit 0e4b8a4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
Signed-off-by: David Osorno <daosgu27@gmail.com> (cherry picked from commit 0e4b8a4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
DarshitChanpura
pushed a commit
that referenced
this pull request
Oct 10, 2023
Member
|
Closing this issue. #3465 has been merged and addresses this issue. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checkstyle is already declare in plugins, not need for extra line.
Issues Resolved
#3355
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.