Skip to content

Redirect deprecation messages to stderr.#3454

Merged
peternied merged 1 commit intoopensearch-project:mainfrom
davidosorno:HashDeprecationMessages
Oct 5, 2023
Merged

Redirect deprecation messages to stderr.#3454
peternied merged 1 commit intoopensearch-project:mainfrom
davidosorno:HashDeprecationMessages

Conversation

@davidosorno
Copy link
Copy Markdown
Contributor

@davidosorno davidosorno commented Oct 4, 2023

Description

  • Redirect deprecation messages to stderr to differentiate between the two streams to make debugging and troubleshooting more efficient.

Issues Resolved

Testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Osorno <daosgu27@gmail.com>
@peternied
Copy link
Copy Markdown
Member

@davidosorno Thanks for creating this PR - seems pretty reasonable to me

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2023

Codecov Report

Merging #3454 (382fa3f) into main (7924da1) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3454      +/-   ##
============================================
+ Coverage     64.56%   64.57%   +0.01%     
- Complexity     3545     3548       +3     
============================================
  Files           269      269              
  Lines         20363    20363              
  Branches       3376     3376              
============================================
+ Hits          13147    13150       +3     
+ Misses         5525     5522       -3     
  Partials       1691     1691              

see 4 files with indirect coverage changes

@peternied
Copy link
Copy Markdown
Member

The BWC tests were blocked because of a known issue that was recently resolved, #3458. Overriding the block due to these test failures.

@peternied peternied merged commit 8752074 into opensearch-project:main Oct 5, 2023
@peternied peternied added the v2.11.0 Issues targeting the 2.11 release label Oct 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
* Redirect deprecation messages to stderr to differentiate between the
two streams to make debugging and troubleshooting more efficient.

Signed-off-by: David Osorno <daosgu27@gmail.com>
(cherry picked from commit 8752074)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwperks
Copy link
Copy Markdown
Member

cwperks commented Oct 5, 2023

@davidosorno would it make sense to apply the same change to the batch script version: hash.bat?

peternied pushed a commit that referenced this pull request Oct 5, 2023
* Redirect deprecation messages to stderr to differentiate between the
two streams to make debugging and troubleshooting more efficient.

Signed-off-by: David Osorno <daosgu27@gmail.com>
(cherry picked from commit 8752074)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied pushed a commit that referenced this pull request Oct 5, 2023
Backport 8752074 from #3454.

Signed-off-by: David Osorno <daosgu27@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot added a commit that referenced this pull request Oct 5, 2023
Backport 8752074 from #3454.

Signed-off-by: David Osorno <daosgu27@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit eadf8a7)
peternied pushed a commit to peternied/security that referenced this pull request Oct 6, 2023
…roject#3460)

Backport 8752074 from opensearch-project#3454.

Signed-off-by: David Osorno <daosgu27@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2.11.0 Issues targeting the 2.11 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] hash.sh script should not return deprecation message in output

4 participants