Minor comments follow up for integration tests#3427
Merged
DarshitChanpura merged 2 commits intoopensearch-project:2.xfrom Oct 16, 2023
Merged
Minor comments follow up for integration tests#3427DarshitChanpura merged 2 commits intoopensearch-project:2.xfrom
DarshitChanpura merged 2 commits intoopensearch-project:2.xfrom
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## 2.x #3427 +/- ##
============================================
- Coverage 64.84% 64.67% -0.17%
+ Complexity 3611 3517 -94
============================================
Files 273 273
Lines 20026 20026
Branches 3346 3346
============================================
- Hits 12986 12952 -34
- Misses 5393 5404 +11
- Partials 1647 1670 +23 |
cwperks
previously approved these changes
Sep 29, 2023
DarshitChanpura
previously approved these changes
Oct 2, 2023
Seems like we still need to force resolve some dependencies.
5e58539 to
974e2ea
Compare
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Member
Author
|
@DarshitChanpura @cwperks Might taking another look, I've updated the description with the new scope of changes |
DarshitChanpura
approved these changes
Oct 16, 2023
cwperks
pushed a commit
to cwperks/security
that referenced
this pull request
Nov 20, 2023
- Remove an unused JVM setting for integration tests - Fixed an issue where you couldn't run non-resource tests unless you had CI_ENVIRONMENT set to normal on your machine (Already fixed in main) - Fixed an issue where code coverage was always run after tests completed (Already fixed in main) - Related opensearch-project#3388 Signed-off-by: Peter Nied <petern@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.