Skip to content

OpenSSL is no longer required for unit/integration tests#339

Merged
vrozov merged 1 commit intoopensearch-project:masterfrom
vrozov:openssl
Apr 1, 2020
Merged

OpenSSL is no longer required for unit/integration tests#339
vrozov merged 1 commit intoopensearch-project:masterfrom
vrozov:openssl

Conversation

@vrozov
Copy link
Copy Markdown
Contributor

@vrozov vrozov commented Apr 1, 2020

Description of changes:

As security plugin dropped support for openssl, it is no longer necessary to have it installed and configured during unit and integration tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vrozov vrozov requested review from debjanibnrj and sujithvm April 1, 2020 00:23
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2020

Codecov Report

Merging #339 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #339      +/-   ##
============================================
+ Coverage     61.89%   61.97%   +0.08%     
- Complexity     2829     2833       +4     
============================================
  Files           218      218              
  Lines         15804    15804              
  Branches       2977     2977              
============================================
+ Hits           9782     9795      +13     
+ Misses         4459     4448      -11     
+ Partials       1563     1561       -2     
Impacted Files Coverage Δ Complexity Δ
...search/security/tools/OpenDistroSecurityAdmin.java 47.83% <0.00%> (-0.14%) 70.00% <0.00%> (-1.00%)
...urity/transport/OpenDistroSecurityInterceptor.java 75.47% <0.00%> (+0.94%) 35.00% <0.00%> (+1.00%)
...earch/security/auditlog/impl/AbstractAuditLog.java 69.90% <0.00%> (+0.97%) 95.00% <0.00%> (+2.00%)
...ecurity/ssl/DefaultOpenDistroSecurityKeyStore.java 73.48% <0.00%> (+1.01%) 68.00% <0.00%> (+1.00%)
...transport/OpenDistroSecuritySSLRequestHandler.java 56.41% <0.00%> (+6.41%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f3dd8...d5b1463. Read the comment docs.

Copy link
Copy Markdown
Contributor

@sujithvm sujithvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrozov vrozov merged commit d5b1463 into opensearch-project:master Apr 1, 2020
@vrozov vrozov deleted the openssl branch April 1, 2020 01:15
gaobinlong pushed a commit to gaobinlong/security that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants