Retry code coverage upload on failure#3242
Merged
willyborankin merged 1 commit intoopensearch-project:mainfrom Aug 25, 2023
Merged
Retry code coverage upload on failure#3242willyborankin merged 1 commit intoopensearch-project:mainfrom
willyborankin merged 1 commit intoopensearch-project:mainfrom
Conversation
3 tasks
3629c0b to
aad739e
Compare
Noticed in several results of https://github.com/opensearch-project/security/actions/runs/5978371801/job/16220344142?pr=3123 that the code coverage upload had failed silently, and the annotations make it look like many tests were not executed. Since in this job there were 9 failures at the same time, adding retry mechanism as well to prevent blind restarting of workflows. Signed-off-by: Peter Nied <petern@amazon.com>
aad739e to
ea73034
Compare
Codecov Report
@@ Coverage Diff @@
## main #3242 +/- ##
============================================
- Coverage 62.51% 62.51% -0.01%
+ Complexity 3353 3351 -2
============================================
Files 254 254
Lines 19732 19732
Branches 3334 3334
============================================
- Hits 12336 12335 -1
- Misses 5767 5769 +2
+ Partials 1629 1628 -1 |
DarshitChanpura
approved these changes
Aug 25, 2023
willyborankin
approved these changes
Aug 25, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3242-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7d7f626042a42626bacd25de4af178b8dc37e18
# Push it to GitHub
git push --set-upstream origin backport/backport-3242-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
peternied
added a commit
that referenced
this pull request
Aug 26, 2023
3 tasks
peternied
added a commit
that referenced
this pull request
Aug 26, 2023
DarshitChanpura
pushed a commit
that referenced
this pull request
Aug 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed in several results of
https://github.com/opensearch-project/security/actions/runs/5978371801/job/16220344142?pr=3123 that the code coverage upload had failed silently, and the annotations make it look like many tests were not executed. Since in this job there were 9 failures at the same time, adding retry mechanism as well to prevent blind restarting of workflows.
Additional background
Solution sourced from this stackoverflow question "How to automatically retry github action jobs on failure?" [1]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.