Adds a test to check similarity between audit logs generated from REST layer and TRANSPORT layer#3192
Merged
DarshitChanpura merged 6 commits intoopensearch-project:mainfrom Aug 21, 2023
Conversation
…T layer and TRANSPORT layer Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
bc5bebb to
f1e0f4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3192 +/- ##
=========================================
Coverage 62.45% 62.45%
+ Complexity 3353 3352 -1
=========================================
Files 254 254
Lines 19748 19748
Branches 3334 3334
=========================================
Hits 12334 12334
Misses 5785 5785
Partials 1629 1629 |
peternied
suggested changes
Aug 16, 2023
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
cwperks
reviewed
Aug 16, 2023
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
8c5adfb to
56586f8
Compare
…message for each of REST and Transport layer Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
peternied
approved these changes
Aug 21, 2023
Member
peternied
left a comment
There was a problem hiding this comment.
Looks good, thanks for drilling in on these scenarios.
RyanL1997
reviewed
Aug 21, 2023
Collaborator
RyanL1997
left a comment
There was a problem hiding this comment.
Hi @DarshitChanpura, thanks for adding the tests. This is looking good to me, and I just left some minor questions for my understanding.
RyanL1997
approved these changes
Aug 21, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3192-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0e3cdcdd7edae90beab5f8c882e5f3fdf25cea7
# Push it to GitHub
git push --set-upstream origin backport/backport-3192-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
6 tasks
Member
Author
|
Backport is currently blocked by #3230 |
Member
|
@DarshitChanpura Can you attach this to the pull request that will incorporate all of the AuthZ in the Rest layer changes into the 2.x branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Resolved
Testing
Integration testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.