[Enchancement] Removed dependency between "test" and "jacocoTestReport" (#2935)

pawel-gudel-eliatra · web-flow · commit 32d3112ad341 · 2023-08-17T16:14:33.000-04:00
As a part of discussions in #2861 there's been determined that CI workflow in Github Actions is excluding a lot of unnecessary task. @nibix created #2913 to address this problem. Most of the unneeded tasks has been already removed in #2861. This PR removes last existing part. @peternied's confirmed removal of dependency in his [comment](#2913 (comment)). This change removes the dependency between "_jacocoTestReport_" and "_test_" tasks. Specifically the dependency that forces to start "_test_" task always when "_jacocoTestReport_" is called. This allows us to always generate coverage report in the end of every task run in "CI" workflow without having to exclude "_test_" task in every single one of them. Unfortunately this will break functionality to create code coverage by starting only "_jacocoTestReport_" task. It looks like this was not used widely and was certainly not used in any of Github Actions Workflows. This will not break creating coverage reports in the end of "_test_" task. Signed-off-by: Pawel Gudel <pawel.gudel@eliatra.com>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -58,7 +58,6 @@ jobs:
         cache-disabled: true
         arguments: |
           ${{ matrix.gradle_task }} -Dbuild.snapshot=false
-          -x test
 
     - name: Coverage
       uses: codecov/codecov-action@v3
diff --git a/build.gradle b/build.gradle
@@ -398,8 +398,6 @@ tasks.withType(JavaCompile) {
 }
 
 tasks.test.finalizedBy(jacocoTestReport)  // report is always generated after tests run
-tasks.jacocoTestReport.dependsOn(test) // tests are required to run before generating the report
-
 
 allprojects {
     tasks.withType(Javadoc).all { enabled = false }

Original file line number	Diff line number	Diff line change
`@@ -398,8 +398,6 @@ tasks.withType(JavaCompile) {`
`398`	`398`	`}`
`399`	`399`
`400`	`400`	`tasks.test.finalizedBy(jacocoTestReport) // report is always generated after tests run`
`401`		`-tasks.jacocoTestReport.dependsOn(test) // tests are required to run before generating the report`
`402`		`-`
`403`	`401`
`404`	`402`	`allprojects {`
`405`	`403`	`tasks.withType(Javadoc).all { enabled = false }`