Skip to content

React to Strings changes from #9103 in core#3110

Merged
cwperks merged 3 commits intoopensearch-project:mainfrom
cwperks:react-to-core
Aug 7, 2023
Merged

React to Strings changes from #9103 in core#3110
cwperks merged 3 commits intoopensearch-project:mainfrom
cwperks:react-to-core

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Aug 7, 2023

Description

React to changes from opensearch-project/OpenSearch#9103 in core

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
React to Strings changes from #9103 in core
ce77e6d 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Use MediaTypeRegistry
3193892 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks mentioned this pull request Aug 7, 2023
Merged
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Aug 7, 2023

The last core SNAPSHOT was published on Friday: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-core/

@opensearch-project/engineering-effectiveness are there any issues publishing snapshots atm?

@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Aug 7, 2023

Looking into the maven snapshot publish failure.

/home/runner/work/OpenSearch/OpenSearch/libs/core/src/main/java/org/opensearch/core/common/util/CollectionUtils.java:143: warning: [unchecked] unchecked generic array creation for varargs parameter of type Iterator<? extends Object>[]
return () -> Iterators.concat(map.keySet().iterator(), map.values().iterator());
^
error: warnings found and -Werror specified

https://github.com/opensearch-project/OpenSearch/actions/runs/5767554873/job/15637408847

@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Aug 7, 2023

Opened a PR in core to address the snapshot publication issue: opensearch-project/OpenSearch#9149

cwperks added a commit that referenced this pull request Aug 7, 2023
@cwperks
[2.x] React to Strings changes from #9103 in core (#3111)
d00d05e 
Backport of #3110 to
2.x

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Aug 7, 2023

Looks like it may be trying to use the SNAPSHOT from the gradle cache...

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #3110 (dd0a97d) into main (07f791a) will decrease coverage by 0.05%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##               main    #3110      +/-   ##
============================================
- Coverage     62.43%   62.38%   -0.05%     
+ Complexity     3353     3349       -4     
============================================
  Files           254      254              
  Lines         19747    19749       +2     
  Branches       3334     3334              
============================================
- Hits          12329    12321       -8     
- Misses         5786     5794       +8     
- Partials       1632     1634       +2
Files Changed Coverage Δ
...nsearch/security/action/whoami/WhoAmIResponse.java 0.00% <0.00%> (ø)
...search/security/auditlog/impl/RequestResolver.java 67.75% <0.00%> (ø)
...search/security/configuration/DlsFlsValveImpl.java 59.23% <0.00%> (-0.42%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 44.40% <0.00%> (ø)
...earch/security/auditlog/impl/AbstractAuditLog.java 75.34% <50.00%> (-1.15%) ⬇️
...pensearch/security/auditlog/impl/AuditMessage.java 74.00% <100.00%> (ø)
...ecurity/configuration/ConfigurationRepository.java 72.28% <100.00%> (ø)

... and 4 files with indirect coverage changes

@cwperks cwperks merged commit 6cc90e6 into opensearch-project:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willyborankin willyborankin willyborankin approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@cliu123 cliu123 Awaiting requested review from cliu123

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

@davidlago davidlago Awaiting requested review from davidlago

@peternied peternied Awaiting requested review from peternied

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@reta reta Awaiting requested review from reta reta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cwperks @willyborankin @RyanL1997