Limit the use of extensions term in the codebase#2748
Merged
peternied merged 3 commits intoopensearch-project:mainfrom May 9, 2023
Merged
Limit the use of extensions term in the codebase#2748peternied merged 3 commits intoopensearch-project:mainfrom
peternied merged 3 commits intoopensearch-project:mainfrom
Conversation
Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently. Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2748 +/- ##
============================================
- Coverage 61.36% 61.35% -0.02%
- Complexity 3413 3414 +1
============================================
Files 272 272
Lines 18850 18850
Branches 3296 3296
============================================
- Hits 11568 11565 -3
- Misses 5684 5687 +3
Partials 1598 1598
|
cwperks
approved these changes
May 9, 2023
RyanL1997
approved these changes
May 9, 2023
sebastianmichalski
pushed a commit
to sebastianmichalski/security
that referenced
this pull request
May 19, 2023
…2748) * Limit the use of extensions term in the codebase Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently. Signed-off-by: Peter Nied <petern@amazon.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…2748) * Limit the use of extensions term in the codebase Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently. Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…2748) * Limit the use of extensions term in the codebase Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently. Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…2748) * Limit the use of extensions term in the codebase Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently. Signed-off-by: Peter Nied <petern@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…2748) * Limit the use of extensions term in the codebase Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently. Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extensions are a big part of what we are building into OpenSearch and Security. While we need these features we should try to build them as generically as possible, this checkstyle scan will help enforce this and also allow for working around the term usage with comments as we do have places where extensions need to be treated differently.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.