Skip to content

Add diagram of how transport actions are checked#2660

Merged
peternied merged 4 commits intoopensearch-project:mainfrom
peternied:transport_action_diagram
May 2, 2023
Merged

Add diagram of how transport actions are checked#2660
peternied merged 4 commits intoopensearch-project:mainfrom
peternied:transport_action_diagram

Conversation

@peternied
Copy link
Copy Markdown
Member

Description

Add diagram of how transport actions are checked onto the readme. This diagram is much easier to see in 'rich' diff mode of the readme.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.51%. Comparing base (3a54873) to head (ab320f3).
⚠️ Report is 1281 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2660      +/-   ##
============================================
- Coverage     61.51%   61.51%   -0.01%     
+ Complexity     3397     3396       -1     
============================================
  Files           272      272              
  Lines         18740    18740              
  Branches       3284     3284              
============================================
- Hits          11528    11527       -1     
  Misses         5613     5613              
- Partials       1599     1600       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks
Copy link
Copy Markdown
Member

cwperks commented Apr 10, 2023

Thank you for adding this @peternied. Do you think it would also be possible to add the relevant extension points that the SecurityPlugin utilizes? getRestHandlerWrapper() to wrap RestRequests to authenticate and enrich the threadcontext with user info and also getActionFilters() to implement authorization?

Copy link
Copy Markdown
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Peter! This looks very good to me. I left one comment but also granted approval so that if you clarify, you don't have to wait for my re-review.

Fix bad arrow in the diagram

Signed-off-by: Peter Nied <petern@amazon.com>
Copy link
Copy Markdown
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Signed-off-by: Peter Nied <peternied@hotmail.com>
@DarshitChanpura
Copy link
Copy Markdown
Member

@peternied CI failures should be fixed once latest changes from main are merged in this branch.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied merged commit a5489a2 into opensearch-project:main May 2, 2023
@peternied peternied deleted the transport_action_diagram branch May 2, 2023 23:50
sebastianmichalski pushed a commit to sebastianmichalski/security that referenced this pull request May 19, 2023
…2660)

* Add diagram of how transport actions are checked

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Jun 13, 2023
…2660)

* Add diagram of how transport actions are checked

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Jun 13, 2023
…2660)

* Add diagram of how transport actions are checked

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
samuelcostae pushed a commit to samuelcostae/security that referenced this pull request Jun 19, 2023
…2660)

* Add diagram of how transport actions are checked

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants