Skip to content

Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278)"#1691

Merged
cliu123 merged 1 commit intoopensearch-project:mainfrom
cliu123:revert_class_name_patch_change_to_support_jdk17
Mar 22, 2022
Merged

Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278)"#1691
cliu123 merged 1 commit intoopensearch-project:mainfrom
cliu123:revert_class_name_patch_change_to_support_jdk17

Conversation

@cliu123
Copy link
Copy Markdown
Member

@cliu123 cliu123 commented Mar 21, 2022 •
edited by peternied
Loading

Description

This PR being reverted is one of the things that would be broken by JDK17. JDK17 support got postponed to 2.0 because we'd like to keep the commits like this one being reverted to support rolling upgrade from ODFE/ES versions to OpenSearch 1.x. But in 2.0, we can revert them to unblock JDK17 since we won't need to support rolling upgrade directly from ODFE/ES versions to OpenSearch 2.0. The upgrade path ODFE -> OpenSearch 1.x -> OpenSearch 2.0 will still be retained.

This reverts commit 4abbafc.

Signed-off-by: cliu123 lc12251109@gmail.com

Issues Resolved

#1653

Testing

UT

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123
Revert "Replace opensearch class names with opendistro class names du…
0e03291 
…ring serialization and restore them back during deserialization (opensearch-project#1278)"

This reverts commit 4abbafc.

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 requested a review from a team March 21, 2022 21:03
@cliu123 cliu123 changed the title Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278) Revert "Replace opensearch class names with opendistro class names during serialization and restore them back during deserialization (#1278)" Mar 21, 2022
@peternied
Copy link
Copy Markdown
Member

peternied commented Mar 21, 2022

@cliu123 Could you add a little detail for why we are reverting this change? At first glance, it seems like we are loosing a level of backward compatibility

@cliu123
Copy link
Copy Markdown
Member Author

cliu123 commented Mar 21, 2022

@cliu123 Could you add a little detail for why we are reverting this change? At first glance, it seems like we are loosing a level of backward compatibility

Sure. This PR being reverted is one of the things that would be broken by JDK17. JDK17 support got postponed to 2.0 because we'd like to keep the commits like this one being reverted to support rolling upgrade from ODFE/ES versions to OpenSearch 1.x. But in 2.0, we can revert them to unblock JDK17 since we won't need to support rolling upgrade directly from ODFE/ES versions to OpenSearch 2.0. The upgrade path ODFE -> OpenSearch 1.x -> OpenSearch 2.0 will still be retained.

@peternied
Copy link
Copy Markdown
Member

peternied commented Mar 21, 2022

Thanks for the details, I'm going to update the description of this PR to include those details and tag it 2.0.0

@cliu123 cliu123 merged commit fa9cd5b into opensearch-project:main Mar 22, 2022
@cliu123 cliu123 deleted the revert_class_name_patch_change_to_support_jdk17 branch March 22, 2022 16:31
@cliu123 cliu123 mentioned this pull request Mar 22, 2022
Closed
@cliu123 cliu123 mentioned this pull request Apr 18, 2022
Closed
@cwperks cwperks mentioned this pull request Nov 4, 2022
Closed
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
@cliu123
Revert "Replace opensearch class names with opendistro class names du…
5b1220d 
…ring serialization and restore them back during deserialization (opensearch-project#1278)" (opensearch-project#1691)

This reverts commit 4abbafc.

Signed-off-by: cliu123 <lc12251109@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.89%. Comparing base (e638c76) to head (0e03291).
⚠️ Report is 1518 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/java/org/opensearch/security/user/User.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1691      +/-   ##
============================================
- Coverage     62.94%   62.89%   -0.06%     
+ Complexity     3261     3259       -2     
============================================
  Files           253      253              
  Lines         18126    18087      -39     
  Branches       3258     3255       -3     
============================================
- Hits          11410    11375      -35     
+ Misses         5067     5063       -4     
  Partials       1649     1649
Files with missing lines Coverage Δ
.../org/opensearch/security/support/Base64Helper.java 67.85% <ø> (-4.78%) ⬇️
...c/main/java/org/opensearch/security/user/User.java 52.63% <33.33%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@peternied peternied peternied approved these changes

@davidlago davidlago davidlago approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v2.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cliu123 @peternied @davidlago