Downgrade Gradle version#1661
Conversation
BWC tooling is built with gradle 6, which has breaking changes that are not compatiable with gradle 7. In order to support BWC tests we need to align with the OpenSearch's gradle version for the 1.3 release. See Also: * Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1622 * Distribution build bugs encountered by plugins opensearch-project/opensearch-build#1247 * Revert of Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1657 Signed-off-by: Peter Nied <petern@amazon.com>
|
Big thanks for @VachaShah for setting me on this path to get the BWC tests working |
Following example from: opensearch-project/common-utils#121 Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
…ssion syntax Signed-off-by: Peter Nied <petern@amazon.com>
|
Do we want to downgrade Gradle in both 1.3 and 2.0? |
Codecov Report
@@ Coverage Diff @@
## main #1661 +/- ##
============================================
+ Coverage 62.92% 62.94% +0.02%
- Complexity 3259 3261 +2
============================================
Files 253 253
Lines 18127 18126 -1
Branches 3258 3258
============================================
+ Hits 11406 11410 +4
+ Misses 5072 5067 -5
Partials 1649 1649
Continue to review full report at Codecov.
|
Signed-off-by: Peter Nied <petern@amazon.com>
@cliu123 Yes - there are gradle files for tests that need to be migrated to gradle 7 before they can be pulled in. This will keep the 2.0 branch stable until those dependent changes have been done. |
|
@opensearch-project/security Could I get another look at this PR? |
|
|
||
| - name: Set up JDK | ||
| - name: Set up JDK for build and test | ||
| if: matrix.jdk != 17 |
There was a problem hiding this comment.
Does JDK17 not support Gradle 6.9?
There was a problem hiding this comment.
Following the example from opensearch-project/common-utils#121
| maxRetries = 5 | ||
| } | ||
| jacoco { | ||
| excludes = [ |
There was a problem hiding this comment.
Why these dependencies need to be excluded from Jacoco?
There was a problem hiding this comment.
In JDK17 these class files are not instrumentable (I don't have the background just dealt with the error), had to remove them to prevent test failures.
None of these exclusions are classes that we implement in our code, and thus do not need to be instrumented for our coverage statistics
|
This change also resolves #1502 |
|
@opensearch-project/security Can I get another look at this PR? |
Signed-off-by: Peter Nied <petern@amazon.com>
3de18de to
e825c26
Compare
|
This missed the 1.3 release, removed those labels. @DarshitChanpura @cliu123 please review and provide feedback so we can move forward with this PR |
|
Addressing the |
DarshitChanpura
left a comment
There was a problem hiding this comment.
White-source check fails can you please check it?
Addressing the @whitesource-for-github-com WhiteSource Security Check Failing in PR #1679 |
|
Wondering if we can retrigger whitesource check after that PR just merged... or perhaps just use admin to override-merge |
|
@davidlago I just merged, when I attempted to re-run the tests it didn't retry the merge from main :/ If I was a more patient person I think rebasing + force push would be the way to go. |
* Downgrade gradle version BWC tooling is built with gradle 6, which has breaking changes that are not compatiable with gradle 7. In order to support BWC tests we need to align with the OpenSearch's gradle version for the 1.3 release. See Also: * Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1622 * Distribution build bugs encountered by plugins opensearch-project/opensearch-build#1247 * Revert of Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1657 Signed-off-by: Peter Nied <petern@amazon.com>
Description
BWC tooling is built with gradle 6, which has breaking changes that are
not compatible with gradle 7. In order to support BWC tests we need to
align with the OpenSearch's gradle version for the 1.3 release.
Issues Resolved
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.