Remove netty-tcnative dependency to unblock security plugin build on ARM64#1649
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Feb 28, 2022
Merged
Conversation
…ARM64 Signed-off-by: cliu123 <lc12251109@gmail.com>
e801616 to
4142bc2
Compare
peterzhuamazon
approved these changes
Feb 28, 2022
peternied
approved these changes
Feb 28, 2022
Member
peternied
left a comment
There was a problem hiding this comment.
Do you know what were these dependencies doing before?
Member
Author
Good question! It was introduced to support OpenSSL that has been discontinued for a while. |
Codecov Report
@@ Coverage Diff @@
## main #1649 +/- ##
============================================
- Coverage 64.59% 64.53% -0.06%
+ Complexity 3214 3213 -1
============================================
Files 247 247
Lines 17352 17351 -1
Branches 3082 3073 -9
============================================
- Hits 11208 11198 -10
- Misses 4594 4596 +2
- Partials 1550 1557 +7
Continue to review full report at Codecov.
|
This was referenced Oct 31, 2022
3 tasks
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…ARM64 (opensearch-project#1649) Signed-off-by: cliu123 <lc12251109@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
netty-tcnative-2.0.25.Finaldoes not support ARM64.Issues Resolved
#1647
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Compile and UTs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.