Modifying UTs and CI to add support for Java 8, 11 and 14#1580
Merged
davidlago merged 1 commit intoopensearch-project:mainfrom Jan 27, 2022
Merged
Modifying UTs and CI to add support for Java 8, 11 and 14#1580davidlago merged 1 commit intoopensearch-project:mainfrom
davidlago merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Nidhi Sridhar <srnidhi@amazon.com>
nsri19
commented
Jan 21, 2022
| <dependency.locations.enabled>false</dependency.locations.enabled> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <maven.compiler.release>8</maven.compiler.release> |
Contributor
Author
There was a problem hiding this comment.
Required because as per the documentation for maven-compiler-plugin, the release flag is supported since 1.9, and thus has to be commented/removed from the POM if using earlier (1.8 and below) versions of JDK.
Maven documentation for release tag for maven-compiler-plugin can be found here.
davidlago
approved these changes
Jan 21, 2022
3 tasks
DarshitChanpura
requested changes
Jan 25, 2022
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
LGTM!
One of the checks failed. Is it expected to? if not, can you please look into it.
|
Whitesource report has been fixed in |
DarshitChanpura
approved these changes
Jan 27, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…-project#1580) Signed-off-by: Nidhi Sridhar <srnidhi@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nidhi Sridhar srnidhi@amazon.com
Description
Adds 8, 11 and 14 to the CI matrix
Modifies UTs to drop TLSv1 and add TLSv1.2 instead
Issues Resolved
#1502
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Manually tested all the changes on my fork.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.