-
Notifications
You must be signed in to change notification settings - Fork 358
Ensure compatibility check readiness #2915
Copy link
Copy link
Closed
Labels
untriagedRequire the attention of the repository maintainers and may need to be prioritizedRequire the attention of the repository maintainers and may need to be prioritizedv2.9.0v2.9.0v2.9.0
Description
Coming from opensearch-project/opensearch-devops#114 (comment)
Overview
In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on publishToMavenLocal task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs ./gradlew assemble.
Action Items
In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:
- The build.gradle file in this repository uses
mavenLocal()as the first entry inrepositories()section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks. -
./gradlew assembletask passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.
Please close this issue once the above checklist is complete.
Thanks!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
untriagedRequire the attention of the repository maintainers and may need to be prioritizedRequire the attention of the repository maintainers and may need to be prioritizedv2.9.0v2.9.0v2.9.0