Add a gradle task to check compability with child components by gaiksaya · Pull Request #7998 · opensearch-project/OpenSearch

gaiksaya · 2023-06-10T03:39:44Z

Description

This change adds a gradle task to check the compatibility with any child projects/components. The task is dependent on publishToMavenLocal as it publishes the core engine to maven local and then clones the remote project in temporary directory and runs ./gradlew assemble.
The task takes 2 inputs:

repositoryUrls: a comma separated git url of the components. Defaults to https://raw.githubusercontent.com/opensearch-project/opensearch-plugins/main/plugins/.meta
ref: branch or reference to checkout. Defaults to main

Run with specific components:

./gradlew checkCompatibility
> Task :checkCompatibility
Incompatible components: [git@github.com:opensearch-project/k-nn.git, git@github.com:opensearch-project/asynchronous-search.git, git@github.com:opensearch-project/anomaly-detection.git, git@github.com:opensearch-project/observability.git, git@github.com:opensearch-project/performance-analyzer-rca.git, git@github.com:opensearch-project/performance-analyzer.git, git@github.com:opensearch-project/reporting.git, git@github.com:opensearch-project/geospatial.git, git@github.com:opensearch-project/sql.git, git@github.com:opensearch-project/cross-cluster-replication.git, git@github.com:opensearch-project/opensearch-oci-object-storage.git, git@github.com:opensearch-project/neural-search.git]
Compatible components: [git@github.com:opensearch-project/job-scheduler.git, git@github.com:opensearch-project/common-utils.git, git@github.com:opensearch-project/notifications.git, git@github.com:opensearch-project/security.git, git@github.com:opensearch-project/alerting.git, git@github.com:opensearch-project/security-analytics.git, git@github.com:opensearch-project/index-management.git, git@github.com:opensearch-project/ml-commons.git]

BUILD SUCCESSFUL in 11m 49s
983 actionable tasks: 821 executed, 90 from cache, 72 up-to-date

Run with all components:

./gradlew checkCompatibility -PrepositoryUrls=https://github.com/opensearch-project/job-scheduler.git,https://github.com/opensearch-project/common-utils.git,https://github.com/opensearch-project/asynchronous-search.git
> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git]
Compatible components: [https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git]

BUILD SUCCESSFUL in 1m 57s
837 actionable tasks: 259 executed, 578 up-to-date

BUILD SUCCESSFUL in 2m 23s
837 actionable tasks: 259 executed, 578 up-to-date

Run with specific branch

./gradlew checkCompatibility -PrepositoryUrls=https://github.com/opensearch-project/common-utils -Pref=lol

> Task :checkCompatibility
Skipping compatibility check for https://github.com/opensearch-project/common-utils
Components skipped due to git failures: [https://github.com/opensearch-project/common-utils]

BUILD SUCCESSFUL in 14s
837 actionable tasks: 255 executed, 582 up-to-date

Related Issues

opensearch-project/opensearch-devops#114 (comment)

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-06-10T04:13:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testSingleIndexShardAllocation

URL: https://build.ci.opensearch.org/job/gradle-check/17268/
CommitID: 6e5b81b
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-06-10T04:14:17Z

Codecov Report

Merging #7998 (92619ee) into main (9c5c6eb) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7998      +/-   ##
============================================
- Coverage     71.01%   70.91%   -0.11%     
+ Complexity    56695    56648      -47     
============================================
  Files          4720     4721       +1     
  Lines        267605   267654      +49     
  Branches      39213    39220       +7     
============================================
- Hits         190047   189814     -233     
- Misses        61569    61859     +290     
+ Partials      15989    15981       -8

Impacted Files	Coverage Δ
...rg/opensearch/gradle/CheckCompatibilityTask.groovy	`0.00% <0.00%> (ø)`

... and 458 files with indirect coverage changes

github-actions · 2023-06-13T02:29:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.indices.replication.SegmentReplicationIT.testCancellation

URL: https://build.ci.opensearch.org/job/gradle-check/17412/
CommitID: ee79488
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-06-13T02:35:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

URL: https://build.ci.opensearch.org/job/gradle-check/17414/
CommitID: bd635b1
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Add compatibility check gradle task ./gradlew checkCompatibility Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> (cherry picked from commit 619aeb5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…8232) Add compatibility check gradle task ./gradlew checkCompatibility (cherry picked from commit 619aeb5) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…rch-project#7998) (opensearch-project#8232) Add compatibility check gradle task ./gradlew checkCompatibility (cherry picked from commit 619aeb5) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…rch-project#7998) Add compatibility check gradle task ./gradlew checkCompatibility Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

…rch-project#7998) Add compatibility check gradle task ./gradlew checkCompatibility Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

gaiksaya force-pushed the check-groovy branch 2 times, most recently from ee79488 to 4466acc Compare June 13, 2023 01:59

gaiksaya marked this pull request as ready for review June 13, 2023 01:59

gaiksaya added the skip-changelog label Jun 13, 2023

andrross added the backport 2.x Backport to 2.x branch label Jun 22, 2023

opensearch-trigger-bot bot mentioned this pull request Jun 22, 2023

[Backport 2.x] Add a gradle task to check compability with child components #8232

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a gradle task to check compability with child components#7998

Add a gradle task to check compability with child components#7998
nknize merged 2 commits intoopensearch-project:mainfrom
gaiksaya:check-groovy

gaiksaya commented Jun 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jun 10, 2023

Uh oh!

codecov bot commented Jun 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jun 13, 2023

Uh oh!

github-actions bot commented Jun 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gaiksaya commented Jun 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Jun 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Jun 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jun 13, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Jun 13, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gaiksaya commented Jun 10, 2023 •

edited

Loading

codecov bot commented Jun 10, 2023 •

edited

Loading