[1.2] Fix reporting validation for observability (#231)#233
Merged
joshuali925 merged 1 commit intoopensearch-project:1.2from Nov 17, 2021
Merged
[1.2] Fix reporting validation for observability (#231)#233joshuali925 merged 1 commit intoopensearch-project:1.2from
joshuali925 merged 1 commit intoopensearch-project:1.2from
Conversation
* Update reporting validation for observability Signed-off-by: Joshua Li <joshuali925@gmail.com> * update tests Signed-off-by: Joshua Li <joshuali925@gmail.com>
davidcui1225
approved these changes
Nov 17, 2021
Contributor
davidcui1225
left a comment
There was a problem hiding this comment.
LGTM- did we get approval to introduce this into 1.2?
Member
Author
No, just opened it in case, but don't merge it yet |
Codecov Report
@@ Coverage Diff @@
## 1.2 #233 +/- ##
============================================
- Coverage 64.54% 54.57% -9.98%
Complexity 294 294
============================================
Files 97 64 -33
Lines 4045 2056 -1989
Branches 620 234 -386
============================================
- Hits 2611 1122 -1489
+ Misses 1293 796 -497
+ Partials 141 138 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
kavithacm
approved these changes
Nov 17, 2021
kavilla
pushed a commit
to kavilla/dashboards-reports
that referenced
this pull request
Jul 12, 2023
…t#233) * Fix path * Fix path for kibana reports * Change s3 bucket paths and artifact name * Fix path * Use kibana-oss in release workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li joshuali925@gmail.com
Description
Backport #231
Issues Resolved
#232
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.