Add ActionListener onFailure to ExtensionsRunner#87
Merged
ryanbogan merged 6 commits intoopensearch-project:mainfrom Sep 17, 2022
Merged
Add ActionListener onFailure to ExtensionsRunner#87ryanbogan merged 6 commits intoopensearch-project:mainfrom
ryanbogan merged 6 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
joshpalis
requested changes
Aug 11, 2022
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
joshpalis
previously approved these changes
Aug 12, 2022
owaiskazi19
requested changes
Aug 12, 2022
Member
owaiskazi19
left a comment
There was a problem hiding this comment.
We need to identify the exceptions here rather than incrementing count
Member
|
@owaiskazi19 @ryanbogan whats needed to keep this moving? |
Member
We need to catch the exception in the OpenSesrch end coming from the extension rather than incrementing/decrementing counts which is present in the current PR. |
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
owaiskazi19
reviewed
Sep 8, 2022
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
owaiskazi19
previously approved these changes
Sep 14, 2022
dbwiddis
previously approved these changes
Sep 16, 2022
Member
dbwiddis
left a comment
There was a problem hiding this comment.
Approved with a big question on why there's a test failure being sent in the production side of code. Is this leftover debug code?
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
9b91ad6
dbwiddis
approved these changes
Sep 16, 2022
owaiskazi19
approved these changes
Sep 16, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Add ActionListener onFailure to ExtensionsRunner Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Removed test failure Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
* Add ActionListener onFailure to ExtensionsRunner Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Removed test failure Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Bogan rbogan@amazon.com
Description
Add ActionListener onFailure to ExtensionsRunner
Issues Resolved
#61
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.