Skip to content

Initial draft of Design for extensions#60

Merged
saratvemulapalli merged 6 commits intoopensearch-project:mainfrom
saratvemulapalli:main
Jul 29, 2022
Merged

Initial draft of Design for extensions#60
saratvemulapalli merged 6 commits intoopensearch-project:mainfrom
saratvemulapalli:main

Conversation

@saratvemulapalli
Copy link
Copy Markdown
Member

Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com

Description

Initial Draft of design for extensions

Issues Resolved

#35

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli requested a review from a team July 25, 2022 17:08
Copy link
Copy Markdown
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

Copy link
Copy Markdown
Collaborator

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for kicking this design for extensions doc. Added comments

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@saratvemulapalli
Copy link
Copy Markdown
Member Author

@owaiskazi19 your force push cleaned up my changes.
For next time, do a rebase and then push your changes :)

I didnt realize until @peternied asked :)

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@owaiskazi19
Copy link
Copy Markdown
Member

@owaiskazi19 your force push cleaned up my changes. For next time, do a rebase and then push your changes :)

I didnt realize until @peternied asked :)

My bad. Did you push those changes or should I take care of it?

@saratvemulapalli
Copy link
Copy Markdown
Member Author

@owaiskazi19 your force push cleaned up my changes. For next time, do a rebase and then push your changes :)
I didnt realize until @peternied asked :)

My bad. Did you push those changes or should I take care of it?

I did, dont worry.

Copy link
Copy Markdown
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a couple of unresolved conversations, @saratvemulapalli @owaiskazi19 did you have any outstanding questions?

@owaiskazi19
Copy link
Copy Markdown
Member

It looks like there are a couple of unresolved conversations, @saratvemulapalli @owaiskazi19 did you have any outstanding questions?

I have one here

@saratvemulapalli saratvemulapalli merged commit f9b3157 into opensearch-project:main Jul 29, 2022

### Settings
Walking through a similar example as plugin above, after extension registration is done, extension makes an API call to register custom settings to OpenSearch.
`ExtensionsOrchestrator` receives the requests, forwards it to `SettingsModule` to register a new setting and wala, the user is now able to toggle the setting via `_settings` Rest API.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/wala/voilà/

kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
* Initial draft of Design for extensions

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding TBD sections

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Added communcation, sdk and latency

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Lint errors

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Moved Latency to FAQ

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Readdressing comments

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
caokyhieu pushed a commit to caokyhieu/opensearch-sdk-java that referenced this pull request Aug 15, 2025
* Initial draft of Design for extensions

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding TBD sections

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Added communcation, sdk and latency

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Lint errors

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Moved Latency to FAQ

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Readdressing comments

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants