Add sample for validator#421
Merged
ryanbogan merged 8 commits intoopensearch-project:mainfrom Mar 10, 2023
Merged
Conversation
dbwiddis
requested changes
Feb 7, 2023
Member
dbwiddis
left a comment
There was a problem hiding this comment.
Good start, see comments inline.
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
Feb 8, 2023
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
dbwiddis
previously approved these changes
Feb 16, 2023
Member
dbwiddis
left a comment
There was a problem hiding this comment.
LGTM (pending merge on opensearch side) but one improvement suggested.
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
owaiskazi19
previously approved these changes
Feb 17, 2023
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Show resolved
Hide resolved
15367b9 to
3c0b93b
Compare
3c0b93b to
2d031f0
Compare
Member
|
@mloufra Can you rebase this PR with main? |
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
2d031f0 to
d681330
Compare
Contributor
Author
Done |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #421 +/- ##
============================================
- Coverage 67.90% 67.67% -0.24%
Complexity 200 200
============================================
Files 35 36 +1
Lines 860 863 +3
Branches 26 26
============================================
Hits 584 584
- Misses 266 269 +3
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ryanbogan
approved these changes
Mar 10, 2023
joshpalis
approved these changes
Mar 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* add sample for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * addressing comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * add test Signed-off-by: Frank Lou <mloufra@amazon.com> * add test case for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * fix merge conflict Signed-off-by: Frank Lou <mloufra@amazon.com> --------- Signed-off-by: Frank Lou <mloufra@amazon.com> (cherry picked from commit 0da23e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan
pushed a commit
that referenced
this pull request
Mar 10, 2023
* add sample for validator * addressing comment * address comment * add test * add test case for validator * address comment * address comment * fix merge conflict --------- (cherry picked from commit 0da23e1) Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 16, 2023
* add sample for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * addressing comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * add test Signed-off-by: Frank Lou <mloufra@amazon.com> * add test case for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * fix merge conflict Signed-off-by: Frank Lou <mloufra@amazon.com> --------- Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: Nurym <nurym0807@gmail.com>
Kuanysh-kst
pushed a commit
to Kuanysh-kst/opensearch-sdk-java
that referenced
this pull request
Mar 18, 2023
* add sample for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * addressing comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * add test Signed-off-by: Frank Lou <mloufra@amazon.com> * add test case for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * fix merge conflict Signed-off-by: Frank Lou <mloufra@amazon.com> --------- Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 19, 2023
* add sample for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * addressing comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * add test Signed-off-by: Frank Lou <mloufra@amazon.com> * add test case for validator Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * fix merge conflict Signed-off-by: Frank Lou <mloufra@amazon.com> --------- Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: Nurym <nurym0807@gmail.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
…#550) * add sample for validator * addressing comment * address comment * add test * add test case for validator * address comment * address comment * fix merge conflict --------- (cherry picked from commit 0da23e1) Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frank Lou mloufra@amazon.com
Description
Create a sample Setting in Hello World Extension package, and using the RegexValidator form the Setting on Opensearch side the validate the value of sample Setting.
Needs OS #6221 to be merged first.
Issues Resolved
Fixes #350
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.