What about pulling in checkstyle to enforce this [check] instead of writing it on your own(https://checkstyle.org/config_imports.html#AvoidStarImport)?

We have removed CheckStyle from OpenSearch to have one formatting tool(Spotless) throughout the repo and following the same here as well.

Ready for review. Initial test failure after adding the check. Tests pass after removing star imports in c0f119d

Note: the error message isn't very informative and I had to hunt down the star imports; however, for future failures they'll likely be part of the diff and much easier to identify. It may be possible to get line numbers but that adds some complexity.

We have removed CheckStyle from OpenSearch to have one formatting tool(Spotless) throughout the repo and following the same here as well.

From opensearch-project/OpenSearch#1362, I see 'it caused issue on plugins side '. Seems like this is a cause of tight build system coupling rather than the tool itself being a problem.

While I agree that removing * imports is a good thing, lack of built-in IDE integration and a host of features that might need to be duplicated for future coverage will be the cost of this pattern.

From opensearch-project/OpenSearch#1362, I see 'it caused issue on plugins side '. Seems like this is a cause of tight build system coupling rather than the tool itself being a problem.

I'm not familiar with the background of the decision to remove Checkstyle from Opensearch and wonder if it could be considered to be brought back for some specific "style" checks that Spotless doesn't do. Spotless is mostly a formatting tool, while Checkstyle also checks things like redundant modifiers, variable naming conventions, etc.

While I agree that removing * imports is a good thing, lack of built-in IDE integration and a host of features that might need to be duplicated for future coverage will be the cost of this pattern.

Not sure how integrated checkstyle is? Don't most IDEs already have an easily toggleable option to remove * imports?

From opensearch-project/OpenSearch#1362, I see 'it caused issue on plugins side '. Seems like this is a cause of tight build system coupling rather than the tool itself being a problem.

We wanted to have only one formatting tool for OpenSearch and that's why asked the Plugin teams to follow the same. Does CheckStyle provides more benefits than Spotless? Something we can think of for the future definitely.