Spec Test Coverage Analysis

Looks good so far! Needs tests (will require updates for the 2.18 and 3.x builds we use in CI).

Changes Analysis

Commit SHA: ca3218f
Comparing To SHA: e41257a

API Changes

Summary

├─┬Paths
│ ├──[➕] path (2804:3)
│ ├──[➕] path (2873:3)
│ ├──[➕] path (2787:3)
│ ├──[➕] path (2903:3)
│ └──[➕] path (2838:3)
└─┬Components
  ├──[➕] responses (29222:7)
  ├──[➕] responses (29276:7)
  ├──[➕] responses (29216:7)
  ├──[➕] parameters (22251:7)
  ├──[➕] parameters (22107:7)
  ├──[➕] parameters (22141:7)
  ├──[➕] parameters (22052:7)
  ├──[➕] parameters (22084:7)
  ├──[➕] parameters (22115:7)
  ├──[➕] parameters (22201:7)
  ├──[➕] parameters (22194:7)
  ├──[➕] parameters (22099:7)
  ├──[➕] parameters (22175:7)
  ├──[➕] parameters (22059:7)
  ├──[➕] parameters (22073:7)
  ├──[➕] parameters (22091:7)
  ├──[➕] parameters (22183:7)
  ├──[➕] parameters (22215:7)
  ├──[➕] parameters (22208:7)
  ├──[➕] parameters (22278:7)
  ├──[➕] parameters (22133:7)
  ├──[➕] parameters (22287:7)
  ├──[➕] parameters (22242:7)
  ├──[➕] parameters (22293:7)
  ├──[➕] parameters (22234:7)
  ├──[➕] parameters (22168:7)
  ├──[➕] parameters (22260:7)
  ├──[➕] parameters (22159:7)
  ├──[➕] parameters (22045:7)
  ├──[➕] parameters (22271:7)
  ├──[➕] parameters (22152:7)
  ├──[➕] parameters (22035:7)
  ├──[➕] parameters (22066:7)
  ├──[➕] parameters (22226:7)
  └──[➕] parameters (22124:7)

• Total Changes: 40
• Additions: 40

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11779538587/artifacts/2171382582

API Coverage

@dblock Can you please take a look again? Added tests taking inspiration from existing _cat APIs. Verified the tests by running them against Amazon Opensearch domain.

The staging 2.18 distribution seems to be missing the _list APIs, and as a result Spec test in CI are failing.

@dblock Thanks for reviewing. I have addressed previous set of comments, please do take a look again whenever you get a chance. Also, sorry for the delay in between the revisions, got occupied with other urgent items.

On the tests, i have updated the staging distributions for 2.18 and 3.0 and the newly added list tests are passing. Not sure why some of the existing ones have started to fail. Trying to root cause.

The 3.0 build gets generated even if not all plugins build with it, so looks like the update SHA doesn't have all the plugins? Try another more recent SHA until the tests all pass, possibly hunt down why the build is failing for the plugins that are failing (geospatial looks like).

Got it, I had sorted the distributions via the newest and used the latest one already. Can this staging build be triggered manually to generate a latest distribution?

The 3.0 build gets generated even if not all plugins build with it, so looks like the update SHA doesn't have all the plugins? Try another more recent SHA until the tests all pass, possibly hunt down why the build is failing for the plugins that are failing (geospatial looks like).

Got it, I had sorted the distributions via the newest and used the latest one already. Can this staging build be triggered manually to generate a latest distribution?

You should try with a newer SHA. The builds happen every day.

If the build is broken (other tests failing, please try another SHA or chase that down).

Looks like the style checker is failing for good reason (use of indices instead of indexes, etc.).

Looks like the style checker is failing for good reason (use of indices instead of indexes, etc.).

We have a namespace called indices that has been around since the beginning of time. Shouldn't it be the other way around where the use indices over indexes?

Looks like the style checker is failing for good reason (use of indices instead of indexes, etc.).

We have a namespace called indices that has been around since the beginning of time. Shouldn't it be the other way around where the use indices over indexes?

The descriptive text was standardized as "indexes", but technically it's "indices" in APIs and such I believe. Let's open an issue in docs about potentially changing that, but for now the style checker is correct.

Test run against 3.0.0 build is the only failing task. Newly added spec tests though are passing, the existing plugin related tests are failing.

@dblock @nhtruong Can you please help with suggestions on 3.0.0 build? I have picked up the latest SHA as part of this PR.
Thanks!

Looks like we don't have a good 3.0 build since with all the plugins, hence the failures :(

Undo the 3.0 hash change and add version: '< 3.0' in the new list tests, maybe with a # TODO: re-enable in 3.0, see https://github.com/opensearch-project/opensearch-api-specification/pull/613.

Undo the 3.0 hash change and add version: '< 3.0' in the new list tests, maybe with a # TODO: re-enable in 3.0, see #613.

@dblock Thanks for the suggestions. The tasks are green now, please take a look whenever you get a chance.
Thanks!

Good work @gargharsh3134, thanks for hanging in here!