Skip to content

Fix compilation errors, change core package name in import#219

Merged
martin-gaievski merged 1 commit intoopensearch-project:mainfrom
martin-gaievski:fix_compilation_errors_after_core_refactoring
Jul 13, 2023
Merged

Fix compilation errors, change core package name in import#219
martin-gaievski merged 1 commit intoopensearch-project:mainfrom
martin-gaievski:fix_compilation_errors_after_core_refactoring

Conversation

@martin-gaievski
Copy link
Copy Markdown
Member

@martin-gaievski martin-gaievski commented Jul 13, 2023

Description

Fix errors after this core refactoring PR

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog v2.10.0 Issues targeting release v2.10.0 labels Jul 13, 2023
@martin-gaievski
Copy link
Copy Markdown
Member Author

martin-gaievski commented Jul 13, 2023

For now that will fail until similar fix is done in "ml-commons" opensearch-project/ml-commons#1122

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the fix_compilation_errors_after_core_refactoring branch from ce0f777 to ab529cc Compare July 13, 2023 22:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2023

Codecov Report

Merging #219 (ab529cc) into main (ca29bce) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #219   +/-   ##
=========================================
  Coverage     89.55%   89.55%           
  Complexity      103      103           
=========================================
  Files             7        7           
  Lines           316      316           
  Branches         52       52           
=========================================
  Hits            283      283           
  Misses           16       16           
  Partials         17       17           
Impacted Files Coverage Δ
...g/opensearch/neuralsearch/plugin/NeuralSearch.java 0.00% <ø> (ø)
...nsearch/neuralsearch/query/NeuralQueryBuilder.java 87.91% <ø> (ø)

@martin-gaievski martin-gaievski merged commit a9adfe0 into opensearch-project:main Jul 13, 2023
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Jul 13, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit a9adfe0)
junqiu-lei pushed a commit that referenced this pull request Jul 31, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit a9adfe0)

Co-authored-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog v2.10.0 Issues targeting release v2.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants