Added hostPort support for http- and transport-ports by kritzeljan · Pull Request #336 · opensearch-project/helm-charts

kritzeljan · 2022-10-12T11:18:01Z

Signed-off-by: Christian Kuhn phello@gmx.de

Description

Added hostPort support for http- and transport-ports

Issues Resolved

#335

Check List

Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

Helm chart version bumped
Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon · 2022-10-12T17:19:04Z

Hi @TheAlgo @prudhvigodithi please take a look at this.
I am ok with the implementation but not sure if there is a specific requirement of these.

Thanks.

TheAlgo · 2022-11-07T12:39:38Z

@prudhvigodithi Please take a look when free. Thanks

peterzhuamazon · 2022-11-12T06:22:06Z

Adding @prudhvigodithi to review a bit I can resolve versions later.

DandyDeveloper

The change is fine but I am curious on the use case here?

Perhaps exposing ports themselves as yaml overrides is needed?

I'm only worried about this weird added bloat from this change. Generally, the change itself LGTM.

TheAlgo · 2022-11-19T17:55:08Z

The change is fine but I am curious on the use case here?

Perhaps exposing ports themselves as yaml overrides is needed?

I'm only worried about this weird added bloat from this change. Generally, the change itself LGTM.

Please find the usecase in this comment

prudhvigodithi · 2022-11-21T15:49:29Z

Hey @ph311o thanks for the PR, can you please resolve the conflicts, so that we can merge this?
Thank you

kritzeljan · 2022-11-22T10:00:37Z

@TheAlgo Seems to me that the "Lint and Test Charts / lint-test" have some issues:
ERROR: failed to create cluster: failed to init node with kubeadm: command "docker exec --privileged chart-testing-control-plane kubeadm init --skip-phases=preflight --config=/kind/kubeadm.conf --skip-token-print --v=6" failed with error: exit status 1

kritzeljan · 2022-12-20T08:39:15Z

@peterzhuamazon @TheAlgo @prudhvigodithi @DandyDeveloper Can you tell me why the tests are not working since November? What do I have to fix?

prudhvigodithi · 2022-12-20T10:54:21Z

Hey @ph311o can you please fetch the changes from upstream, I believe this was fixed in issue #355.
Thank you

Signed-off-by: Christian Kuhn <phello@gmx.de>

kritzeljan · 2022-12-21T14:39:11Z

@prudhvigodithi Thank you for that hint. I have fetched upstream.

kritzeljan · 2023-01-03T17:10:03Z

Dear @peterzhuamazon @TheAlgo @prudhvigodithi @DandyDeveloper

could anyone please finally merge my pull request or is there still any problem?

Thanks

TheAlgo · 2023-01-03T17:18:57Z

Dear @peterzhuamazon @TheAlgo @prudhvigodithi @DandyDeveloper

could anyone please finally merge my pull request or is there still any problem?

Thanks

I have just triggered CI. Once it passes we are good to merge

prudhvigodithi · 2023-01-03T18:32:58Z

Thanks @ph311o and @TheAlgo should we backport this to 1.x?

TheAlgo · 2023-01-05T05:06:22Z

@prudhvigodithi Yes I think we should backport this. @ph311o Do you want to do this or I can take care of it?

kritzeljan · 2023-01-06T11:16:29Z

Could you please take care of backport?Thank youAm 05.01.2023 um 06:06 schrieb Dhiraj Kumar Jain ***@***.***>: @prudhvigodithi Yes I think we should backport this. @ph311o Do you want to do this or I can take care of it? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

…t#336) Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Service port for performance analyzer (#346) * Performance analyzer port mapping Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> * Performance analyzer port on ci-values Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> * Update changelog Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add hostPort support for http- and transport-ports (#336) Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Christian Kuhn <phello@gmx.de> Co-authored-by: Philipp Hölscher <46397932+Phoelsch@users.noreply.github.com> Co-authored-by: Christian Kuhn <86721442+ph311o@users.noreply.github.com>

…t#336) Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update appVersion for 2.4.0 release (#350) Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add .whitesource configuration file (#353) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Resolve Kind Cluster not able to be built in PR checks (#356) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix the kindest/node docker images versions (#357) * Resolve Kind Cluster not able to be built in PR checks Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix the kindest/node versions on docker images Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Resolve Kind Cluster not able to be built in PR checks (#358) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * allow adding plugins and change defaultmode for opensearch dashboards (#342) * allow adding plugins and change defaultmode for opensearch dashboards yaml file Signed-off-by: Lu Yu <nluyu@amazon.com> * bump version and update changelog Signed-off-by: Lu Yu <nluyu@amazon.com> * add new line Signed-off-by: Lu Yu <nluyu@amazon.com> * bump version for os Signed-off-by: Lu Yu <nluyu@amazon.com> * resolve conflict in changelog Signed-off-by: Lu Yu <nluyu@amazon.com> * trigger build Signed-off-by: Lu Yu <nluyu@amazon.com> Signed-off-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix path in securityConfig section on OpenSearch (values.yaml) (#344) * fix securityConfig.path Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> * add link to issue Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update appVersion to 2.4.1 (#363) * Update appVersion to 2.4.1 Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Update appVersion to 2.4.1 Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix changelog Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix changelog Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix version Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix version for OpenSearch Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix version for OpenSearch-Dasboards Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add hostPort support for http- and transport-ports (#336) Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#367) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Bump OS and OSD version to 2.5.0 (#373) Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Created untriaged issue workflow. (#382) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Bump OpenSearch and Dashboards to 2.6.0 (#393) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updating the CODEOWNERS file (#399) Signed-off-by: bbarani <bbarani@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add lifecycle support in opensearch container (#376) * Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * feat: Add user-defined labels option to ingress (#390) Signed-off-by: Jason Witkowski <jwitkowski@zscaler.com> Co-authored-by: Jason Witkowski <jwitkowski@zscaler.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update deployment.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update values.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update values.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update statefulset.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updating chart version and changelog.md Signed-off-by: Prathap Mahalingam (Nokia) <prathap.mahalingam@nokia.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add lifecycle support in opensearch container (#376) * Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add github-merit-badger.yml (#408) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Service port for performance analyzer (#346) * Performance analyzer port mapping Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> * Performance analyzer port on ci-values Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> * Update changelog Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Incorporated the review comments Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update values.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Incorporated the review comments Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Correcting the merge conflicts Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updated the README.md for OpenSearch & Dashboard Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updated the changelog message Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updating the version number Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> --------- Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Lu Yu <nluyu@amazon.com> Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: bbarani <bbarani@amazon.com> Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: Jason Witkowski <jwitkowski@zscaler.com> Signed-off-by: Prathap Mahalingam (Nokia) <prathap.mahalingam@nokia.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Lu Yu <yulu.nju@gmail.com> Co-authored-by: Ruslan Gainanov <gromrx1@gmail.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Christian Kuhn <86721442+ph311o@users.noreply.github.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org> Co-authored-by: Rishabh Singh <rishabhksingh@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Barani <70038446+bbarani@users.noreply.github.com> Co-authored-by: Joseph Teddick <43552317+josephteddick@users.noreply.github.com> Co-authored-by: Jason Witkowski <jason@witkow.ski> Co-authored-by: Jason Witkowski <jwitkowski@zscaler.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> Co-authored-by: Philipp Hölscher <46397932+Phoelsch@users.noreply.github.com>

kritzeljan requested review from a team, DandyDeveloper and TheAlgo as code owners October 12, 2022 11:18

kritzeljan changed the title ~~Added hostPort support for http- and transport-ports #335~~ Added hostPort support for http- and transport-ports Oct 12, 2022

TheAlgo requested changes Oct 23, 2022

View reviewed changes

Comment thread charts/opensearch/Chart.yaml

Comment thread charts/opensearch/README.md Outdated

Comment thread charts/opensearch/values.yaml Outdated

Comment thread charts/opensearch/templates/statefulset.yaml Outdated

kritzeljan requested review from TheAlgo and removed request for DandyDeveloper November 7, 2022 08:38

TheAlgo requested a review from prudhvigodithi November 7, 2022 12:39

DandyDeveloper approved these changes Nov 13, 2022

View reviewed changes

TheAlgo approved these changes Nov 21, 2022

View reviewed changes

Added hostPort support for http- and transport-ports

3c4cf03

Signed-off-by: Christian Kuhn <phello@gmx.de>

TheAlgo merged commit 1a2ba74 into opensearch-project:main Jan 3, 2023

TheAlgo mentioned this pull request Jan 3, 2023

[Enhancement][opensearch] Add hostPort support for http- and transport-ports #335

Closed

peterzhuamazon pushed a commit to peterzhuamazon/helm-charts that referenced this pull request Mar 23, 2023

Add hostPort support for http- and transport-ports (opensearch-projec…

3a4d671

…t#336) Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon mentioned this pull request Mar 23, 2023

Backport #336 #346 #411

Merged

3 tasks

Conversation

kritzeljan commented Oct 12, 2022

Description

Issues Resolved

Check List

Uh oh!

peterzhuamazon commented Oct 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheAlgo commented Nov 7, 2022

Uh oh!

peterzhuamazon commented Nov 12, 2022

Uh oh!

DandyDeveloper left a comment

Choose a reason for hiding this comment

Uh oh!

TheAlgo commented Nov 19, 2022

Uh oh!

prudhvigodithi commented Nov 21, 2022

Uh oh!

kritzeljan commented Nov 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kritzeljan commented Dec 20, 2022

Uh oh!

prudhvigodithi commented Dec 20, 2022

Uh oh!

kritzeljan commented Dec 21, 2022

Uh oh!

kritzeljan commented Jan 3, 2023

Uh oh!

TheAlgo commented Jan 3, 2023

Uh oh!

prudhvigodithi commented Jan 3, 2023

Uh oh!

TheAlgo commented Jan 5, 2023

Uh oh!

kritzeljan commented Jan 6, 2023 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kritzeljan commented Nov 22, 2022 •

edited

Loading