correct ISM job_interval description and default#10545
correct ISM job_interval description and default#10545kolchfa-aws merged 2 commits intoopensearch-project:mainfrom
Conversation
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
left a comment
There was a problem hiding this comment.
Thanks, @Aeternax! Do other time values (like plugins.index_state_management.coordinator.sweep_period and plugins.index_state_management.coordinator.backoff_millis) need to be modified as well? Also, could you please fix DCO so we can merge the PR?
Signed-off-by: Marco Arts <marcoarts88@gmail.com>
4a2c0db to
af19580
Compare
Signed-off-by: Marco Arts <marcoarts88@gmail.com>
Hi @kolchfa-aws, I honestly didn't really check/think about it before, just ran into this setting. |
kolchfa-aws
left a comment
There was a problem hiding this comment.
LGTM. Thank you, @Aeternax!
* correct job_interval description and default Signed-off-by: Marco Arts <marcoarts88@gmail.com> * show correct format for default values Signed-off-by: Marco Arts <marcoarts88@gmail.com> --------- Signed-off-by: Marco Arts <marcoarts88@gmail.com> Co-authored-by: Marco Arts <marcoarts88@gmail.com> (cherry picked from commit b82ad2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This corrects the table on job_intervals, as it lists "5 minutes" as a value, which doesn't work.
Not much else to say here.
Version
all (none, just documentation)