Update source field descriptions in update by query API#10278
Update source field descriptions in update by query API#10278
Conversation
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@mgodwan Could you review this PR? |
|
@bharath-techie @dhwanilpatel Could either of you review this PR? |
| _source | String | Whether to include the `_source` field in the response. | ||
| _source_excludes | String | A comma-separated list of source fields to exclude from the response. | ||
| _source_includes | String | A comma-separated list of source fields to include in the response. | ||
| _source | String | Controls the parts of the document source available to the script and returned in the response. Excluded fields may be removed from the document if not reassigned in the script. |
There was a problem hiding this comment.
parts of the document: possible to make this more clear? I find the word parts ambiguous. Like fields of the document source available?
Excluded fields may be removed from the document _source if not reassigned in the script?
| _source_excludes | String | A comma-separated list of source fields to exclude from the response. | ||
| _source_includes | String | A comma-separated list of source fields to include in the response. | ||
| _source | String | Controls the parts of the document source available to the script and returned in the response. Excluded fields may be removed from the document if not reassigned in the script. | ||
| _source_excludes | String | A comma-separated list of source fields to exclude from the script context and the response. Excluded fields may be removed from the document unless explicitly preserved by the script. |
There was a problem hiding this comment.
document _source? Is this more meaningful?
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
|
@sandeshkr419 Suggestions added. Could you take a look again? |
sandeshkr419
left a comment
There was a problem hiding this comment.
Thanks @kolchfa-aws for the making the changes, LGTM!
* Update source field descriptions in update by query API Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Apply suggestions from code review Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit 3555cda) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closes #9613
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.