Fix breaking changes in otel_logs_source#6572
Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom Feb 27, 2026
Merged
Fix breaking changes in otel_logs_source#6572graytaylor0 merged 1 commit intoopensearch-project:mainfrom
graytaylor0 merged 1 commit intoopensearch-project:mainfrom
Conversation
…vice support Signed-off-by: Hai Yan <oeyh@amazon.com>
dlvenable
approved these changes
Feb 27, 2026
| @Test | ||
| void start_withoutHttpPath_doesNotThrowNPE() { | ||
| final OTelLogsSourceConfig config = createDefaultConfigBuilder() | ||
| .httpPath(null) |
Member
There was a problem hiding this comment.
I think we should invert this. Most tests should set httpPath to null and we only have one that sets it.
I'm fine with merging this fix now, but think we should update in a quick follow-on.
graytaylor0
approved these changes
Feb 27, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit 8d85609 (#6250) added HTTP service support to otel_logs_source but introduced regressions that break existing users:
resolving to different plugin implementations. The original code used a single GrpcAuthenticationProvider for both.
All changes are confined to OTelLogsSource.java:
removing the split-provider pattern and the now-dead createHttpAuthentication() helper
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.