Use a Timer for the sqsSinkRequestLatency metric to report it with time units#6513
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Feb 16, 2026
Merged
Conversation
…eports it with correct units. Signed-off-by: David Venable <dlv@amazon.com>
kkondaka
approved these changes
Feb 16, 2026
graytaylor0
reviewed
Feb 16, 2026
| pushFailedObjectsToDlq(failedStatus); | ||
| } else { | ||
| recordLatency((double)System.nanoTime() - startTime); | ||
| recordLatency(System.nanoTime() - startTime, TimeUnit.NANOSECONDS); |
Member
There was a problem hiding this comment.
Why do we use nanoseconds here instead of just milliseconds?
Member
Author
There was a problem hiding this comment.
That is the current resolution that we report. So I didn't change it.
But, it shouldn't matter much. Micrometer will send these using units and CloudWatch can normalize them for operators.
Member
There was a problem hiding this comment.
Ok if cloudwatch normalizes then that's good. We should just be seeing consistent numbers for latency on metrics across Data Prepper
graytaylor0
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This uses a Micrometer
Timerfor thesqsSinkRequestLatencymetrics. This will have it report using time units.See a similar PR #6510 for more information.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.