Use a Timer for the sinkRequestLatency to report it with time units#6510
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Feb 16, 2026
Merged
Conversation
…rts it with correct units. Adds a new method to record with time units and retains the existing method for double. Update usage of this as well. Signed-off-by: David Venable <dlv@amazon.com>
4 tasks
graytaylor0
approved these changes
Feb 16, 2026
kkondaka
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
sinkRequestLatencymetric is usingDistributionSummary. This means that Micrometer will not report units. This PR changes this to aTimerso that it includes time units.Adds a new method to record with time units. Retains the existing method for double. Update usage of this as well.
Per Micrometer documentation:
This is an alternative solution to the problem identified in #6508.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.