Fix Sink Metrics Request Latency Metric units#6508
Closed
kkondaka wants to merge 1 commit intoopensearch-project:mainfrom
Closed
Fix Sink Metrics Request Latency Metric units#6508kkondaka wants to merge 1 commit intoopensearch-project:mainfrom
kkondaka wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
reviewed
Feb 13, 2026
| SinkFlushResult flushResult = flushableBuffer.flush(); | ||
| if (flushResult == null) { // success | ||
| sinkMetrics.recordRequestLatency((double)(System.nanoTime() - startTime)); | ||
| double latency = (System.nanoTime() - startTime)/1000_000; // convert to ms |
Member
There was a problem hiding this comment.
This would be clearer: 1_000_000
Member
|
@kkondaka , I labeled this as a breaking change so that we can note it in the release notes. I think it is the right solution, but we just need to be clear on it. |
dlvenable
requested changes
Feb 13, 2026
Member
dlvenable
left a comment
There was a problem hiding this comment.
I have an alternative approach and will send a PR shortly.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make Sink Metrics Request Latency Metric units as milliseconds because all other latency metrics in the pipeline are in milliseconds
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.