remove usage of buffer accumulator from Kafka custom consumer#6357
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Dec 16, 2025
Merged
Conversation
03a3bdc to
b8ffd80
Compare
Signed-off-by: Taylor Gray <tylgry@amazon.com>
b8ffd80 to
021f5b8
Compare
kkondaka
reviewed
Dec 15, 2025
| } else { | ||
| bufferAccumulator.flush(); | ||
| } | ||
| buffer.writeAll(eventRecords, BUFFER_WRITE_TIMEOUT); |
Collaborator
There was a problem hiding this comment.
I think the "topicMetrics.getNumberOfBufferSizeOverflows().increment();" needs to be modified as well to keep track of how times we got this timeout exception. Maybe check for "SizeOverflowException" can be removed as well?
Member
Author
There was a problem hiding this comment.
Well we are still tracking SizeOverflowException only in the code below where we check the exception type. If you look at the buffer code you can see that we already have a metric for TimeoutException here (
kkondaka
approved these changes
Dec 15, 2025
dlvenable
approved these changes
Dec 16, 2025
wandna-amazon
pushed a commit
to wandna-amazon/data-prepper
that referenced
this pull request
Jan 8, 2026
…arch-project#6357) Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: Nathan Wand <wandna@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…arch-project#6357) Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…arch-project#6357) Signed-off-by: Taylor Gray <tylgry@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…arch-project#6357) Signed-off-by: Taylor Gray <tylgry@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change removes the buffer accumulator in favor of directly calling
buffer.writeAll. This is because BufferAccumulator does not throw TimeoutException, and instead will do infinite back off and retry to write to the buffer during TimeoutExceptions. This causes the consumer thread processing the records to get blocked, which stopspollfrom getting called on the consumer, which can result in the consumer being removed from the group after themax.poll.interval.msexpires, which leads to Kafka rebalances.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.