Ensure shards are completed when last getRecords call has no records and no shardIterator#5958
Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom Aug 4, 2025
Conversation
e10e866 to
a514de7
Compare
graytaylor0
previously approved these changes
Aug 4, 2025
divbok
approved these changes
Aug 4, 2025
…and no shardIterator Signed-off-by: Jonah Calvo <caljonah@amazon.com>
a514de7 to
00fa895
Compare
graytaylor0
approved these changes
Aug 4, 2025
graytaylor0
added a commit
to graytaylor0/data-prepper
that referenced
this pull request
Aug 5, 2025
…records and no shardIterator (opensearch-project#5958)" This reverts commit 13049d3. Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
added a commit
that referenced
this pull request
Aug 5, 2025
* Revert "Ensure shards are completed when last getRecords call has no records and no shardIterator (#5958)" This reverts commit 13049d3. Signed-off-by: Taylor Gray <tylgry@amazon.com> * Revert "Introduce checkpointing per shard to DDB source, via ShardAcknowledgementManager class (#5818)" This reverts commit dfc3c70. Signed-off-by: Taylor Gray <tylgry@amazon.com> --------- Signed-off-by: Taylor Gray <tylgry@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in #5818 where shards would not be completed when getRecords returned no records and a null shardIterator
Issues Resolved
Resolves #4764
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.