Bump armeria + grpc + protobuf to fix CVE-2024-7254#5891
Merged
dlvenable merged 3 commits intoopensearch-project:mainfrom Jul 30, 2025
Merged
Bump armeria + grpc + protobuf to fix CVE-2024-7254#5891dlvenable merged 3 commits intoopensearch-project:mainfrom
dlvenable merged 3 commits intoopensearch-project:mainfrom
Conversation
Member
|
@KarstenSchnitter , Thank you for this contribution! To fix the failing tests, try changing the mock annotations for the |
Upgrades protobuf dependencies with versions that fix CVE-2024-7254. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
…g final classes. Signed-off-by: David Venable <dlv@amazon.com>
… to the Armeria test library. Enforce a consistent JUnit version across the project to avoid JUnit consistency issues. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
approved these changes
Jul 30, 2025
Member
dlvenable
left a comment
There was a problem hiding this comment.
I made some changes to get this to work. Thanks @KarstenSchnitter !
graytaylor0
approved these changes
Jul 30, 2025
san81
approved these changes
Jul 30, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Bump armeria + grpc + protobuf to fix CVE-2024-7254 Upgrades protobuf dependencies with versions that fix Fixes CVE-2024-7254. Use inline mocks in DnsPeerListProviderCreationTest to support mocking final classes. Updates to the GrpcRequestExceptionHandlerTest required by the update to the Armeria test library. Enforce a consistent JUnit version across the project to avoid JUnit consistency issues. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com> Signed-off-by: David Venable <dlv@amazon.com> Co-authored-by: David Venable <dlv@amazon.com> (cherry picked from commit 292a547)
dlvenable
added a commit
that referenced
this pull request
Jul 30, 2025
Bump armeria + grpc + protobuf to fix CVE-2024-7254 Upgrades protobuf dependencies with versions that fix Fixes CVE-2024-7254. Use inline mocks in DnsPeerListProviderCreationTest to support mocking final classes. Updates to the GrpcRequestExceptionHandlerTest required by the update to the Armeria test library. Enforce a consistent JUnit version across the project to avoid JUnit consistency issues. (cherry picked from commit 292a547) Signed-off-by: Karsten Schnitter <k.schnitter@sap.com> Signed-off-by: David Venable <dlv@amazon.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: David Venable <dlv@amazon.com>
Collaborator
Author
|
@dlvenable thanks for picking this up. I did not manage to get these changes working locally. For some reason the tests failed when I tried. Thanks also for backporting this. Any plan on a release containing this fix? |
Member
|
@KarstenSchnitter , I'd like to get a release out next week. |
Member
|
@KarstenSchnitter , Data Prepper 2.12.1 is now available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades protobuf dependencies with versions that fix CVE-2024-7254.
Issues Resolved
Resolves #5890
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.