Add multi-line csv support#5784
Merged
kkondaka merged 2 commits intoopensearch-project:mainfrom Jun 16, 2025
Merged
Conversation
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
oeyh
reviewed
Jun 16, 2025
Comment on lines
+100
to
+103
| Event clonedEvent = JacksonEvent.fromEvent(event); | ||
| final List<String> row = messageIterator.nextValue(); | ||
| putDataInEvent(clonedEvent, header, row); | ||
| recordsOut.add(new Record<Event>(clonedEvent)); |
Collaborator
There was a problem hiding this comment.
Since this is creating new events, do we need to add them to acknowledgment set of the original event? Similar to what was done for SplitEventProcessor
Collaborator
Author
There was a problem hiding this comment.
Good point. Thanks for pointing it out. I missed that.
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
oeyh
approved these changes
Jun 16, 2025
sb2k16
approved these changes
Jun 16, 2025
| "is parsed. If there is no event header, no action is taken. Default value is true.") | ||
| private Boolean deleteHeader = DEFAULT_DELETE_HEADERS; | ||
|
|
||
| @JsonProperty(value = "multi_line", defaultValue = "false") |
Member
There was a problem hiding this comment.
should we have multiline as the name.
JonahCalvo
pushed a commit
to JonahCalvo/os-data-prepper
that referenced
this pull request
Jul 17, 2025
* Add multi-line csv support Signed-off-by: Krishna Kondaka <krishkdk@amazon.com> * Addressed review comments Signed-off-by: Krishna Kondaka <krishkdk@amazon.com> --------- Signed-off-by: Krishna Kondaka <krishkdk@amazon.com> Signed-off-by: Jonah Calvo <caljonah@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add multi-line csv support. When the
multi_lineconfig option is used, the input in the source key is expected to contain multiple lines of CSV format with first line containing column names.Issues Resolved
Resolves #5783
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.