Increase default scroll time per batch from 1m to 10m#5704
Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom May 21, 2025
Merged
Increase default scroll time per batch from 1m to 10m#5704graytaylor0 merged 1 commit intoopensearch-project:mainfrom
graytaylor0 merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Taylor Gray <tylgry@amazon.com>
sb2k16
approved these changes
May 20, 2025
dinujoh
approved these changes
May 20, 2025
alparish
pushed a commit
to alparish/data-prepper
that referenced
this pull request
May 22, 2025
…ject#5704) Signed-off-by: Taylor Gray <tylgry@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default scroll time of 1 minute is too low, and can cause the scroll to expire if it takes longer than a minute to write a batch to the buffer (which can happen in full buffer or circuit breaker situations). To handle this, the default is being increased to 10 minutes.
Issues Resolved
Resolves #5679
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.