Fix log warnings for HTTP server with source name#5689
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom May 12, 2025
Merged
Fix log warnings for HTTP server with source name#5689dlvenable merged 1 commit intoopensearch-project:mainfrom
dlvenable merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
4 tasks
KarstenSchnitter
approved these changes
May 12, 2025
Collaborator
KarstenSchnitter
left a comment
There was a problem hiding this comment.
Thanks, looks good to me.
dlvenable
approved these changes
May 12, 2025
alparish
pushed a commit
to alparish/data-prepper
that referenced
this pull request
May 22, 2025
…roject#5689) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The log warning message point to http source in the common create server http interfaces. This can be misleading the users to debug errors hence, changing this warning to point to the
sourceNamesimilar to how it is done for the GRPC server.,Issues Resolved
#5677 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.