Enabling experimental plugins specifically by plugin type and name#5676
Enabling experimental plugins specifically by plugin type and name#5676dlvenable merged 2 commits intoopensearch-project:mainfrom
Conversation
… name. This also includes a change to the core plugin classes to allow them to define themselves as a plugin component type along with a name that is used to create the mapping in the YAML file. Resolves opensearch-project#5675 Signed-off-by: David Venable <dlv@amazon.com>
| * | ||
| * @return The name of the plugin component type. | ||
| */ | ||
| String value(); |
There was a problem hiding this comment.
Could you have better to be an enum instead of a String?
There was a problem hiding this comment.
The reason I didn't use an enum is that this annotation is defined on the types themselves. For example, on the Source interface. I felt that making an enum would result in two places that need the modifications.
|
The mapping will go into a separate file? or additional entries in the data-prepper config file? |
san81
left a comment
There was a problem hiding this comment.
Just asked two clarifying questions. Other than that, it looks good to me.
This is part of |
| @JsonProperty("enable_all") | ||
| private boolean enableAll = false; | ||
|
|
||
| @JsonProperty("enabled") |
There was a problem hiding this comment.
This name might be misunderstood as boolean flag. Maybe enabled_plugins?
Signed-off-by: David Venable <dlv@amazon.com>
…pensearch-project#5676) Support enabling experimental plugins specifically by plugin type and name. This also includes a change to the core plugin classes to allow them to define themselves as a plugin component type along with a name that is used to create the mapping in the YAML file. Resolves opensearch-project#5675 Signed-off-by: David Venable <dlv@amazon.com>
Description
Support enabling experimental plugins specifically by plugin type and name.
This also includes a change to the core plugin classes to allow them to define themselves as a plugin component type along with a name that is used to create the mapping in the YAML file.
Issues Resolved
Resolves #5675
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.