Skip to content

Allow plugins to access default pipeline role via AwsCredentialsSupplier#5604

Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom
fidelity-contributions:fix-issue-4958
Jun 10, 2025
Merged

Allow plugins to access default pipeline role via AwsCredentialsSupplier#5604
graytaylor0 merged 1 commit intoopensearch-project:mainfrom
fidelity-contributions:fix-issue-4958

Conversation

@saketh-pallempati
Copy link
Copy Markdown
Contributor

Description

This change enables plugins to access the default STS role ARN configured in
data-prepper-config.yaml via the AwsCredentialsSupplier interface.

Changes:

  • Added getDefaultStsRoleArn() method to AwsCredentialsSupplier interface
  • Implemented the method in DefaultAwsCredentialsSupplier
  • Added corresponding method to CredentialsProviderFactory
  • Added unit tests for the new functionality

This maintains a consistet pattern with how the default region is already
accessible to plugins through the same interface.

Issues Resolved

Resolves #4958

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…sSupplier

                  This change enables plugins to access the default STS role ARN configured in
                  data-prepper-config.yaml via the AwsCredentialsSupplier interface.

                  Changes:
                  - Added getDefaultStsRoleArn() method to AwsCredentialsSupplier interface
                  - Implemented the method in DefaultAwsCredentialsSupplier
                  - Added corresponding method to CredentialsProviderFactory
                  - Added unit tests for the new functionality

                  This maintains a consistent pattern with how the default region is already
                  accessible to plugins through the same interface.

Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
Copy link
Copy Markdown
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @saketh-pallempati !

@saketh-pallempati
Copy link
Copy Markdown
Contributor Author

Thanks for approval @dlvenable

@graytaylor0 graytaylor0 merged commit 3a063c7 into opensearch-project:main Jun 10, 2025
45 of 47 checks passed
jeffreyAaron pushed a commit to jeffreyAaron/data-prepper that referenced this pull request Jun 13, 2025
…sSupplier (opensearch-project#5604)

This change enables plugins to access the default STS role ARN configured in
                  data-prepper-config.yaml via the AwsCredentialsSupplier interface.

                  Changes:
                  - Added getDefaultStsRoleArn() method to AwsCredentialsSupplier interface
                  - Implemented the method in DefaultAwsCredentialsSupplier
                  - Added corresponding method to CredentialsProviderFactory
                  - Added unit tests for the new functionality

                  This maintains a consistent pattern with how the default region is already
                  accessible to plugins through the same interface.

Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
Signed-off-by: Jeffrey Aaron Jeyasingh <jeffreyaaron06@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow plugins to access the default pipeline role

3 participants