Add bucket_owner option to S3 DLQ#5519
Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom Mar 18, 2025
Merged
Conversation
Signed-off-by: Taylor Gray <tylgry@amazon.com>
sb2k16
approved these changes
Mar 17, 2025
chenqi0805
approved these changes
Mar 18, 2025
| private void doWrite(final List<DlqObject> dlqObjects, final String pipelineName, final String pluginId) throws IOException { | ||
| final PutObjectRequest putObjectRequest = PutObjectRequest.builder() | ||
| .bucket(bucket) | ||
| .expectedBucketOwner(bucketOwner) |
Collaborator
There was a problem hiding this comment.
Is it backward compatible if bucketOwner is none?
Member
Author
There was a problem hiding this comment.
Yes you can pass null here and it won't apply a bucket owner
chenqi0805
pushed a commit
to chenqi0805/data-prepper
that referenced
this pull request
Apr 2, 2025
Signed-off-by: Taylor Gray <tylgry@amazon.com>
chenqi0805
pushed a commit
to chenqi0805/data-prepper
that referenced
this pull request
Apr 2, 2025
Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: George Chen <qchea@amazon.com>
amdhing
pushed a commit
to amdhing/data-prepper
that referenced
this pull request
Apr 16, 2025
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Mamol27
pushed a commit
to Mamol27/data-prepper
that referenced
this pull request
May 6, 2025
Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: mamol27 <mamol27@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a
bucket_ownerconfiguration option to the S3 DLQ and passes this bucket owner toexpectedBucketOwnerin the PutObject request.Issues Resolved
Resolves #5498
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.