Conversation
* Added validation for sink routes in PipelineConfigurationValidator * Added unit tests in PipelineConfigurationValidatorTest * Added integration tests in PipelineConfigurationValidatorIT * Routes now properly validate against defined conditional routes Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
|
Thanks @saketh-pallempati! This change looks good. Re-ran the builds as those are failing |
Hi @graytaylor0 I don't see any relation to build errors and my code changes. Can you please help me out a bit to get the PR merged. |
You should be able to run |
|
@graytaylor0 Thanks for the information will check on my end and get back |
…e Configuration Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
|
Hi @graytaylor0, |
@graytaylor0 Thank you |
...src/main/java/org/opensearch/dataprepper/pipeline/parser/PipelineConfigurationValidator.java
Show resolved
Hide resolved
...src/main/java/org/opensearch/dataprepper/pipeline/parser/PipelineConfigurationValidator.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/opensearch/dataprepper/pipeline/parser/PipelineConfigurationValidatorIT.java
Show resolved
Hide resolved
san81
left a comment
There was a problem hiding this comment.
Thank you for this nice fix. Just handling null route cases will make this fix ready to go
|
Will work on the changes and get back. Thanks for the suggestions @san81 |
…ases Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
|
Hi @san81 I made the requried changes can you check the new commit. |
dlvenable
left a comment
There was a problem hiding this comment.
Thanks @saketh-pallempati for this change. This will be a nice improvement for users.
|
@saketh-pallempati build is failing with some format violations. Please fix them |
Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
Sorry that's an unused import error. Will submit a fix ASAP. |
|
Thank you @saketh-pallempati ! |
Fix validation of pipeline's sink routes opensearch-project#5106 * Added validation for sink routes in PipelineConfigurationValidator * Added unit tests in PipelineConfigurationValidatorTest * Added integration tests in PipelineConfigurationValidatorIT * Routes now properly validate against defined conditional routes Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
Fix validation of pipeline's sink routes opensearch-project#5106 * Added validation for sink routes in PipelineConfigurationValidator * Added unit tests in PipelineConfigurationValidatorTest * Added integration tests in PipelineConfigurationValidatorIT * Routes now properly validate against defined conditional routes Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
Description
Issues Resolved
Resolves #5106
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.