Common server builder and auth module for push based plugins#5423
Conversation
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
…rver builder into common module checkpoint) Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
…o more build error lets go hooray ya Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
|
I updated the target branch to |
dlvenable
left a comment
There was a problem hiding this comment.
@Galactus22625 , These are good changes overall. This will be a good improvement to the project. I left a few comments.
| */ | ||
|
|
||
| package org.opensearch.dataprepper.plugins.source.loghttp; | ||
| package org.opensearch.dataprepper.plugins.server; |
There was a problem hiding this comment.
Why was this class moved entirely as-is? This code is very specific to the http source. It is not connected directly to how to create a server or authentication.
There was a problem hiding this comment.
oh, I should pass this in as an argument instead probably
|
|
||
| public class ConvertConfiguration { | ||
|
|
||
| public static ServerConfiguration convertConfiguration(final OTelLogsSourceConfig oTelLogsSourceConfig) { |
There was a problem hiding this comment.
If ServerConfiguration were an interface instead of a class with concrete methods, we could either have an adapter or possibly even inherit from that class.
There was a problem hiding this comment.
good idea. simple for otel/grpc sources. for http I think the config extends a different interface, but can probably migrate it over.
There was a problem hiding this comment.
or as an abstract class maybe
There was a problem hiding this comment.
ok i changed serverconfiguration over to an abstract class for grpc and used the httpconfiguration for http
I think this is a good idea |
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
|
Test were passing at this commit 9293e4f, but have started failing after trying to migrate serverConfiguration to abstract class. May need to revert changes or just fix |
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
68b7be2
into
opensearch-project:common-server-builder-and-auth-module
…rch-project#5423) Common server builder and auth module for push based plugins Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com> Signed-off-by: Siqi Ding <dingdd@amazon.com>
…rch-project#5423) Common server builder and auth module for push based plugins Signed-off-by: Maxwell Brown <55033421+Galactus22625@users.noreply.github.com>
…rch-project#5423) Common server builder and auth module for push based plugins Signed-off-by: Maxwell Brown <55033421+Galactus22625@users.noreply.github.com>
…rch-project#5423) Common server builder and auth module for push based plugins Signed-off-by: Maxwell Brown <55033421+Galactus22625@users.noreply.github.com>
…rch-project#5423) Common server builder and auth module for push based plugins Signed-off-by: Maxwell Brown <55033421+Galactus22625@users.noreply.github.com>
Common server builder and auth module for push based plugins (#5423) Add Custom Auth Provider with support for gRPC, plus tests and exception handling Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com> Signed-off-by: Siqi Ding <109874435+Davidding4718@users.noreply.github.com> Co-authored-by: Maxwell Brown <55033421+Galactus22625@users.noreply.github.com>
Description
Creating a common module for push based plugins to create server
Testing
Tested on local machine:
Original Unit tests from http source and otel logs, trace, and metrics sources pass
Tested http source pipeline works
Tested otel logs pipeline works
tested otel trace pipeline works
tested otel metrics pipeline works
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.