Set the JVM file encoding to UTF-8. #5420
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Feb 7, 2025
Merged
Conversation
Signed-off-by: David Venable <dlv@amazon.com>
graytaylor0
approved these changes
Feb 6, 2025
kkondaka
approved these changes
Feb 7, 2025
chenqi0805
pushed a commit
to chenqi0805/data-prepper
that referenced
this pull request
Apr 2, 2025
…opensearch-project#5420) Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: George Chen <qchea@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets the JVM default encoding to UTF-8 by including
-Dfile.encoding=UTF-8in the JVM arguments. With this, we use UTF-8 by default. I found that this fixes writing to S3 with Unicode data.Some data I got out of S3 with this fix.
Issues Resolved
Resolves #5238.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.