Add support for multiple entries of 'with_keys' with 'delete_when' co…#5356
Merged
dlvenable merged 3 commits intoopensearch-project:mainfrom Apr 21, 2025
Merged
Conversation
…ndition in delete_entries processor Signed-off-by: Niketan Chandarana <niketanc@amazon.com>
graytaylor0
previously approved these changes
Feb 12, 2025
shenkw1
reviewed
Feb 12, 2025
| ) | ||
| }) | ||
| @JsonPropertyOrder | ||
| @JsonClassDescription("The <code>delete_entries</code> processor deletes fields from events. " + |
Contributor
There was a problem hiding this comment.
Include that the user can either use with_keys or entries configuration to define the keys they want to delete, and not both.
Contributor
Author
There was a problem hiding this comment.
As discussed internally, this will be handled on the UI side, so the 2 ifthenelse configs are sufficient here.
| @JsonProperty("with_keys") | ||
| @EventKeyConfiguration(EventKeyFactory.EventAction.DELETE) | ||
| @JsonPropertyDescription("A list of keys to be deleted.") | ||
| @JsonPropertyDescription("A list of keys to be deleted (legacy format).") |
Contributor
There was a problem hiding this comment.
specify in description that only one of with_keys and entries can be defined.
Member
There was a problem hiding this comment.
Let's not include legacy format in here. Just say something like A list of keys to be deleted. May not be used with entries..
...ava/org/opensearch/dataprepper/plugins/processor/mutateevent/DeleteEntryProcessorConfig.java
Show resolved
Hide resolved
…te_when` parameters of the older format. Signed-off-by: Niketan Chandarana <niketanc@amazon.com>
dlvenable
approved these changes
Apr 17, 2025
graytaylor0
approved these changes
Apr 17, 2025
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
opensearch-project#5356) Add support for multiple entries of 'with_keys' with 'delete_when' condition in delete_entries processor Signed-off-by: Niketan Chandarana <niketanc@amazon.com>
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
opensearch-project#5356) Add support for multiple entries of 'with_keys' with 'delete_when' condition in delete_entries processor Signed-off-by: Niketan Chandarana <niketanc@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndition in delete_entries processor
Description
These changes add the support for multiple entries of
with_keyswithdelete_whencondition in thedelete_entriesprocessorIssues Resolved
Resolves #5315
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.