Fix otel_logs_source server configuration for getHttpAuthenticationService#5212
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Nov 21, 2024
Merged
Conversation
…o also support the getHttpAuthenticationService() alternative approach. Signed-off-by: David Venable <dlv@amazon.com>
dinujoh
approved these changes
Nov 21, 2024
chenqi0805
approved these changes
Nov 21, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-5212-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c9cdebcdb5c26901d68659ec8ae017693681900
# Push it to GitHub
git push --set-upstream origin backport/backport-5212-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10Then, create a pull request where the |
dlvenable
added a commit
to dlvenable/data-prepper
that referenced
this pull request
Nov 25, 2024
…o also support the getHttpAuthenticationService() alternative approach. (opensearch-project#5212) Signed-off-by: David Venable <dlv@amazon.com> (cherry picked from commit 6c9cdeb)
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Data Prepper plugins can implement authentication for gRPC sources using
GrpcAuthenticationProvider::getHttpAuthenticationServiceinstead ofGrpcAuthenticationProvider::getAuthenticationInterceptor.The
otel_logs_sourceis not supporting that alternative approach.This fixes the behavior, but it does not affect the current authentication mechanisms provided since they use
getAuthenticationInterceptor.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.