FIX: missed exception in plugin error#4945
Merged
chenqi0805 merged 3 commits intoopensearch-project:mainfrom Oct 24, 2024
Merged
FIX: missed exception in plugin error#4945chenqi0805 merged 3 commits intoopensearch-project:mainfrom
chenqi0805 merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
oeyh
previously approved these changes
Sep 13, 2024
Collaborator
oeyh
left a comment
There was a problem hiding this comment.
Thanks for adding the tests!
Signed-off-by: George Chen <qchea@amazon.com>
oeyh
approved these changes
Oct 24, 2024
dlvenable
approved these changes
Oct 24, 2024
Member
dlvenable
left a comment
There was a problem hiding this comment.
@chenqi0805 , Should we backport this to 2.10?
Collaborator
Author
@dlvenable Thanks for the reminder. I added the label |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
* FIX: missed exception in plugin error building Signed-off-by: George Chen <qchea@amazon.com> (cherry picked from commit 13dccc4)
dlvenable
pushed a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a miss in assigning pluginError with exception
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.