Skip to content

Updated MAINTAINERS.md format.#108

Merged
macohen merged 1 commit intoopensearch-project:mainfrom
dblock:updated-maintainers
Jan 5, 2023
Merged

Updated MAINTAINERS.md format.#108
macohen merged 1 commit intoopensearch-project:mainfrom
dblock:updated-maintainers

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Jan 5, 2023

Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format.

@dblock dblock requested a review from a team January 5, 2023 18:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #108 (c03bc4e) into main (052c593) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          13       13           
  Lines         140      140           
  Branches       27       27           
=======================================
  Hits          114      114           
  Misses         24       24           
  Partials        2        2
Flag Coverage Δ
dashboards-search-relevance 81.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock
Copy link
Copy Markdown
Member Author

dblock commented Jan 5, 2023

Looks like some CI has failed. This change has no code changes, can someone please take a look at that?

@dblock dblock mentioned this pull request Jan 5, 2023
Closed
25 tasks
macohen
macohen approved these changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@macohen macohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Stats needed to be disabled for all checks to pass. This action is only supposed to add a comment to the PR with statistics on the project, but fails due to permissions in the opensearch-project org. Will merge anyway...

@macohen macohen merged commit 97ad0b5 into opensearch-project:main Jan 5, 2023
github-actions Bot added a commit that referenced this pull request Jan 5, 2023
@github-actions
Updated MAINTAINERS.md to match recommended opensearch-project format. (
ca8a8dc 
#108)

Signed-off-by: dblock <dblock@amazon.com>

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 97ad0b5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jan 5, 2023
Merged
@dblock dblock mentioned this pull request Jan 5, 2023
Closed
87 tasks
@dblock dblock deleted the updated-maintainers branch January 5, 2023 22:35
@dblock
Copy link
Copy Markdown
Member Author

dblock commented Jan 5, 2023

PR Stats needed to be disabled for all checks to pass. This action is only supposed to add a comment to the PR with statistics on the project, but fails due to permissions in the opensearch-project org. Will merge anyway...

Thanks, will you please take care of PR stats?

noCharger pushed a commit that referenced this pull request Jan 6, 2023
@github-actions
Updated MAINTAINERS.md to match recommended opensearch-project format. (
d62c912 
#108) (#109)

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 97ad0b5)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mingshl mingshl added the maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream. label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@macohen macohen macohen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dblock @codecov-commenter @macohen @mingshl