Merged
Conversation
* added support for param in Finding API Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added detectionType as param for Findings API enhancements Signed-off-by: Riya Saxena <riysaxen@amazon.com> * adding addiional params findingIds, startTime and endTime Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix klint errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 892c34f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #606 +/- ##
============================================
- Coverage 72.83% 72.81% -0.03%
- Complexity 865 869 +4
============================================
Files 133 133
Lines 5845 5870 +25
Branches 717 717
============================================
+ Hits 4257 4274 +17
- Misses 1274 1281 +7
- Partials 314 315 +1 ☔ View full report in Codecov by Sentry. |
engechas
approved these changes
Mar 9, 2024
eirsep
approved these changes
Mar 9, 2024
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…ect#606) * added support for param in Finding API * added detectionType as param for Findings API enhancements * adding addiional params findingIds, startTime and endTime * fix klint errors --------- (cherry picked from commit 892c34f) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 892c34f from #596.