Added function for request recreation that considers the writeable re…#303
Merged
eirsep merged 2 commits intoopensearch-project:mainfrom Nov 1, 2022
Conversation
…gistry used for parsing the aggregations Added unit tests that checks if the bucket level monitor requests are created and ser/de correctly Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Codecov Report
@@ Coverage Diff @@
## main #303 +/- ##
============================================
+ Coverage 73.32% 73.37% +0.04%
- Complexity 696 697 +1
============================================
Files 110 110
Lines 4563 4564 +1
Branches 605 605
============================================
+ Hits 3346 3349 +3
+ Misses 966 965 -1
+ Partials 251 250 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eirsep
requested changes
Nov 1, 2022
Member
eirsep
left a comment
There was a problem hiding this comment.
Thanks for catching this issue and fixing it Stevan. Left a couple minor comments
| } | ||
| ) | ||
| } | ||
| /** |
Member
There was a problem hiding this comment.
let's not overload index monitor method. Let's change the original method's signature
| randomBucketLevelMonitor() | ||
| ) | ||
|
|
||
| val recreatedObject = recreateObject(req, NamedWriteableRegistry(SearchModule(Settings.EMPTY, emptyList()).namedWriteables)) { IndexMonitorRequest(it) } |
Member
There was a problem hiding this comment.
let's have a test method where recreate object method WITHOUT NamedWriteableRegistry fails and in the same method let's verify that recreate Object WITH NamedWriteableRegistry passes using an actual aggregation in IndexMonitorRequest.
Contributor
Author
There was a problem hiding this comment.
Good point. Let me try to do that
…consider scenario when recreation of aggregation monitor fails Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
eirsep
approved these changes
Nov 1, 2022
getsaurabh02
approved these changes
Nov 1, 2022
sbcd90
approved these changes
Nov 1, 2022
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Nov 2, 2022
#303) (#304) * Added function for request recreation that considers the writeable registry used for parsing the aggregations Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 6a169f7) Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com> (cherry picked from commit 2b2f242)
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
opensearch-project#303) (opensearch-project#304) * Added function for request recreation that considers the writeable registry used for parsing the aggregations Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 6a169f7) Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
opensearch-project#303) (opensearch-project#304) * Added function for request recreation that considers the writeable registry used for parsing the aggregations Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 6a169f7) Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gistry used for parsing the aggregations
Added unit tests that checks if the bucket level monitor requests are created and ser/de correctly
Signed-off-by: Stevan Buzejic stevan.buzejic@htecgroup.com
Description
This PR enables serialization/de-serialization of bucket level monitors.
Adds two new methods - recreateObject which is responsible to re-create objects by using the namedWriteableRegistry
and indexMonitor - which calls recreateObject taking into the account namedWriteableRegistry
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.