Removal of NotificationEvent Request, Response and SearchResults#153
Merged
adityaj1107 merged 2 commits intoopensearch-project:mainfrom Apr 5, 2022
adityaj1107:events-doc-removal-2-main
Merged
Removal of NotificationEvent Request, Response and SearchResults#153adityaj1107 merged 2 commits intoopensearch-project:mainfrom adityaj1107:events-doc-removal-2-main
adityaj1107 merged 2 commits intoopensearch-project:mainfrom
adityaj1107:events-doc-removal-2-main
Conversation
added 2 commits
April 4, 2022 17:31
Addition of NotificationEventDoc and Removal of NotificationEventInfo Addition of NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com>
Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com>
dbbaughe
approved these changes
Apr 5, 2022
qreshi
approved these changes
Apr 5, 2022
zelinh
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Removal of NotificationEvent Request, Response , Search Results Addition of NotificationEventDoc and Removal of NotificationEventInfo Addition of NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> * Removing NotificationEventDoc and NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> Co-authored-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
…nsearch-project#153) * Removal of NotificationEvent Request, Response , Search Results Addition of NotificationEventDoc and Removal of NotificationEventInfo Addition of NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> * Removing NotificationEventDoc and NotificationEventDocTests Signed-off-by: Jindal <aditjind@88665a235f8e.ant.amazon.com> Co-authored-by: Jindal <aditjind@88665a235f8e.ant.amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
Data Models of
GetNotificationEvent API from
NotificationsPluginInterfaceCluster permissions in Notification Actions
Tests for
NotificationPluginInterface,GetNotificationEventRequestTests,GetNotificationEventResponseTests,NotificationEventInfoTests,NotificationEventSearchResultTests, ``Issues Resolved
Removal of code as part of: opensearch-project/notifications#394
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.