Fix broken link in the Overview page#314
Merged
mihirsoni merged 1 commit intoopensearch-project:mainfrom Apr 28, 2021
Merged
Conversation
|
✅ DCO Check Passed 6339a91 |
mihirsoni
reviewed
Apr 24, 2021
Contributor
mihirsoni
left a comment
There was a problem hiding this comment.
Thanks @vchrombie for the PR, I have few small comments.
|
✅ DCO Check Passed 32177ce |
|
✅ DCO Check Passed 286ff0c |
|
✅ DCO Check Passed c36c78c |
boktorbb
suggested changes
Apr 26, 2021
Contributor
boktorbb
left a comment
There was a problem hiding this comment.
After pulling the PR down, I notice that the link works now but it doesn't seamlessly route to the sample data path like on the home screen but actually reloads the whole dashboards app. While this works, it isn't fully the experience we want. Could you take a look there?
The 'Try our sample data' link in the opensearch dashboards overview page is broken. It has to be pointed to the path `/app/home#/tutorial_directory/sampleData`. This commit fixes this bug. The snapshots are updated accordingly. Signed-off-by: Venu Vardhan Reddy Tekula <venu@bitergia.com>
Contributor
Author
|
Hi boktorbb-amzn, thanks for the review.
Nice catch, you are right. I could fix the issue and updated the PR too. Can you look at this again? |
|
✅ DCO Check Passed f81948c |
boktorbb
approved these changes
Apr 27, 2021
Contributor
boktorbb
left a comment
There was a problem hiding this comment.
The link is redirecting properly now. Looks good to me and thank you for your contribution!
kavilla
approved these changes
Apr 27, 2021
Member
kavilla
left a comment
There was a problem hiding this comment.
LGTM! One integ test failing but unrelated to this and currently being fixed. Otherwise unit and functional tests are passing.
Thank you!
kavilla
pushed a commit
that referenced
this pull request
May 21, 2021
The 'Try our sample data' link in the opensearch dashboards overview page is broken. It has to be pointed to the path `/app/home#/tutorial_directory/sampleData`. This commit fixes this bug. The snapshots are updated accordingly. Fixes #193 Signed-off-by: Venu Vardhan Reddy Tekula <venu@bitergia.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
* [Workspace]Add permission control logic for workspace (opensearch-project#6052) * Add permission control for workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * Add changelog for permission control in workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix integration tests and remove no need type Signed-off-by: Lin Wang <wonglam@amazon.com> * Update permission enabled for workspace CRUD integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Change back to config schema Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: do not append workspaces field when no workspaces present (#6) * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: do not append workspaces field when no workspaces present Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: authInfo destructure (#7) * fix: authInfo destructure Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Fix permissions assign in attributes Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove deleteByWorkspace since not exists Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: remove formatWorkspacePermissionModeToStringArray Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove current not used code Signed-off-by: Lin Wang <wonglam@amazon.com> * Add missing unit tests for permission control Signed-off-by: Lin Wang <wonglam@amazon.com> * Update workspaces API test describe Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace CRUD API integration tests failed Signed-off-by: Lin Wang <wonglam@amazon.com> * Address PR comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Store permissions when savedObjects.permissions.enabled Signed-off-by: Lin Wang <wonglam@amazon.com> * Add permission control for deleteByWorkspace Signed-off-by: Lin Wang <wonglam@amazon.com> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Update src/plugins/workspace/server/permission_control/client.ts Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Refactor permissions field in workspace create and update API Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace CRUD API integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> * Convert permission settings in client side Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace list always render Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 'Try our sample data' link in the opensearch dashboards overview page is broken. It has to be pointed to the path
/app/home#/tutorial_directory/sampleData. This commit fixes this bug. The snapshots are updated accordingly.Issues Resolved
Fixes #193
Check List